Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8140

Remove unfinished admin-extra support in angular UI

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: 6.2
    • Fix Version/s: 6.3, 7.0
    • Component/s: None
    • Labels:
      None

      Description

      noted by Upayavira in SOLR-6688...

      I haven't yet implemented admin-extra in the new UI. I haven't yet seen any clear use-cases documented to give me any real idea of how it would be used.

      I didn't see a clear issue tracking this, so i'm openeing one to discuss the merits of the feature and track implementing if (if that's the final decision)

        Issue Links

          Activity

          Hide
          hossman Hoss Man added a comment -

          Ok, so as far as usecases go, files like this one are historically why support for admin-extra.html have always existed in the Solr UI (going back to pre-apache Solr 1.0) ...

          <div>
            <ul style="list-style: outside">
              <li><b>PRIMARY CONTACT: <a href="http://intranet.company.com/~joesmith">Joe Smith</a></b></li>
              <li><a href="http://intranet.company.com/engineering/docs/search/product-collection">Detailed documentation about the schema design, data flow, and SLA for this collection</a></li>
              <li><a href="http://svn.intranet.company.com/search/product-collection">Canonical configs</a>
              <li><a href="../products/select?q=foo&facet.field=...">Sample Query</a>
            </ul>
            <br/>
            <p>
              This collection contains all <em>active</em> products that are currently either available for sale, announced for future sale, or recently disconntinued but still listed for SEO (ie: not archived historical pricing data).  Documents are updated in real time as principle product data (ie: core fields and editorial reviews) are <a href="http://intranet.company.com/engineering/docs/search/product-collection/abc">published</a>, additional <a href="http://intranet.company.com/engineering/docs/search/product-collection/xyz">batch jobs</a> re-index all products with new popularity metrics from the data wharehousing  4 times a day.
            </p>
            <br/>
            <p>
              This collection is available for any team that needs to fetch product data using id lookups, or inline basic searches into other contexts -- however any users with a need for deep analytics or heavy faceting should first consult with the primary contact about capacity planning. <em>Any application usage that will result in more then 100 req/sec must be approved by <a href="http://intranet.company.com/engineering/capacity-planning-team">the capacity planning team</a>
            </p>
          </div>
          

          I, personally, think there is a lot of value in supporting files like that in Solr.

          As far as usecases for admin-extra.menu-bottom.html and admin-extra.menu-top.html ... my recollection is that when the "left nav" was introduced there were people who liked the idea of only including admin-extra.html on the "overview" page for a core (i think previously it was included at the top of every admin page?) and having an easy way for people to inject links into the menu. The primary usecase i remember was for linking to "custom admin screens" generated from Velocity templates (ie: to create a custom search page with specific fields corrisponding to the usecase)

          Show
          hossman Hoss Man added a comment - Ok, so as far as usecases go, files like this one are historically why support for admin-extra.html have always existed in the Solr UI (going back to pre-apache Solr 1.0) ... <div> <ul style="list-style: outside"> <li><b>PRIMARY CONTACT: <a href="http://intranet.company.com/~joesmith">Joe Smith</a></b></li> <li><a href="http://intranet.company.com/engineering/docs/search/product-collection">Detailed documentation about the schema design, data flow, and SLA for this collection</a></li> <li><a href="http://svn.intranet.company.com/search/product-collection">Canonical configs</a> <li><a href="../products/select?q=foo&facet.field=...">Sample Query</a> </ul> <br/> <p> This collection contains all <em>active</em> products that are currently either available for sale, announced for future sale, or recently disconntinued but still listed for SEO (ie: not archived historical pricing data). Documents are updated in real time as principle product data (ie: core fields and editorial reviews) are <a href="http://intranet.company.com/engineering/docs/search/product-collection/abc">published</a>, additional <a href="http://intranet.company.com/engineering/docs/search/product-collection/xyz">batch jobs</a> re-index all products with new popularity metrics from the data wharehousing 4 times a day. </p> <br/> <p> This collection is available for any team that needs to fetch product data using id lookups, or inline basic searches into other contexts -- however any users with a need for deep analytics or heavy faceting should first consult with the primary contact about capacity planning. <em>Any application usage that will result in more then 100 req/sec must be approved by <a href="http://intranet.company.com/engineering/capacity-planning-team">the capacity planning team</a> </p> </div> I, personally, think there is a lot of value in supporting files like that in Solr. As far as usecases for admin-extra.menu-bottom.html and admin-extra.menu-top.html ... my recollection is that when the "left nav" was introduced there were people who liked the idea of only including admin-extra.html on the "overview" page for a core (i think previously it was included at the top of every admin page?) and having an easy way for people to inject links into the menu. The primary usecase i remember was for linking to "custom admin screens" generated from Velocity templates (ie: to create a custom search page with specific fields corrisponding to the usecase)
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          I love the idea of the admin-extra myself. But even in the old UI, admin-extra is broken (overzealous style reset). Menus extras were a bit better, but also did not integrate in any meaningful way. All of this also caused continuous log message issues, polluted access log, and so on.

          I am going ahead with removing admin-extra from Angular UI. I would welcome a new ticket with a discussion of a concrete use case to implement this better later.

          Show
          arafalov Alexandre Rafalovitch added a comment - I love the idea of the admin-extra myself. But even in the old UI, admin-extra is broken (overzealous style reset). Menus extras were a bit better, but also did not integrate in any meaningful way. All of this also caused continuous log message issues, polluted access log, and so on. I am going ahead with removing admin-extra from Angular UI. I would welcome a new ticket with a discussion of a concrete use case to implement this better later.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9f187eceae930f298e9cb793835dac7e95f97634 in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9f187ec ]

          SOLR-8140: Remove unfinished admin-extra
          Includes UI element and never-implemented commented-out code

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9f187eceae930f298e9cb793835dac7e95f97634 in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9f187ec ] SOLR-8140 : Remove unfinished admin-extra Includes UI element and never-implemented commented-out code
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5b106620698c103027066341a0e16a675541a31a in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5b10662 ]

          SOLR-8140: Remove unfinished admin-extra
          Includes UI element and never-implemented commented-out code

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5b106620698c103027066341a0e16a675541a31a in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5b10662 ] SOLR-8140 : Remove unfinished admin-extra Includes UI element and never-implemented commented-out code
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 472e8048ad5e27913824e9018096a67f6183d7cb in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=472e804 ]

          SOLR-8140: Fix CHANGES file, was missing commiter name

          Show
          jira-bot ASF subversion and git services added a comment - Commit 472e8048ad5e27913824e9018096a67f6183d7cb in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=472e804 ] SOLR-8140 : Fix CHANGES file, was missing commiter name
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          admin-extra are removed from html, css, and (already commented out) Javascript

          Show
          arafalov Alexandre Rafalovitch added a comment - admin-extra are removed from html, css, and (already commented out) Javascript

            People

            • Assignee:
              arafalov Alexandre Rafalovitch
              Reporter:
              hossman Hoss Man
            • Votes:
              4 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development