Solr
  1. Solr
  2. SOLR-8130

Solr's hdfs safe mode detection does not catch all cases of being in safe mode.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: hdfs
    • Labels:
      None

      Activity

      Hide
      Mark Miller added a comment -

      This patch uses the client to determine safe mode rather than trying to decipher remote exceptions. I found this via what Hbase does to handle the same issue.

      Show
      Mark Miller added a comment - This patch uses the client to determine safe mode rather than trying to decipher remote exceptions. I found this via what Hbase does to handle the same issue.
      Hide
      Mark Miller added a comment -

      I'll commit this shortly, Mike Drob has already taken a look at it for me and pointed out I was missing passing a 'true' param on checking if we were in safe mode. Mistranslation when taking it from reflection compatibility code.

      I've also heavily tested manually entering and exiting safe mode pretty heavily. It's much more difficult to simulate a natural safe mode situation. Given Hbase uses the code and has for a long time and the difference in using a proper (though odd), client side API (unlike the current method that depends on catching exceptions passed through a remote class), we can expect that if it works for manual safe mode, it will work for naturally entered safe mode.

      Show
      Mark Miller added a comment - I'll commit this shortly, Mike Drob has already taken a look at it for me and pointed out I was missing passing a 'true' param on checking if we were in safe mode. Mistranslation when taking it from reflection compatibility code. I've also heavily tested manually entering and exiting safe mode pretty heavily. It's much more difficult to simulate a natural safe mode situation. Given Hbase uses the code and has for a long time and the difference in using a proper (though odd), client side API (unlike the current method that depends on catching exceptions passed through a remote class), we can expect that if it works for manual safe mode, it will work for naturally entered safe mode.
      Hide
      ASF subversion and git services added a comment -

      Commit 1707974 from Mark Miller in branch 'dev/trunk'
      [ https://svn.apache.org/r1707974 ]

      SOLR-8130: Solr's hdfs safe mode detection does not catch all cases of being in safe mode.

      Show
      ASF subversion and git services added a comment - Commit 1707974 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1707974 ] SOLR-8130 : Solr's hdfs safe mode detection does not catch all cases of being in safe mode.
      Hide
      ASF subversion and git services added a comment -

      Commit 1707975 from Mark Miller in branch 'dev/branches/branch_5x'
      [ https://svn.apache.org/r1707975 ]

      SOLR-8130: Solr's hdfs safe mode detection does not catch all cases of being in safe mode.

      Show
      ASF subversion and git services added a comment - Commit 1707975 from Mark Miller in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1707975 ] SOLR-8130 : Solr's hdfs safe mode detection does not catch all cases of being in safe mode.

        People

        • Assignee:
          Mark Miller
          Reporter:
          Mark Miller
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development