Solr
  1. Solr
  2. SOLR-8094

HdfsUpdateLog should not replay buffered documents as a replacement to dropping them.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      This can cause replicas to get out of sync because replication may have failed, but then if you replay you can setup peer sync to pass when it should not.

      After talking to Yonik a bit, I tried doing everything the same as on local fs except skipping the truncate - because of error handling we already have, this appears to work.

        Issue Links

          Activity

          Hide
          Mark Miller added a comment -

          Patch attached.

          Show
          Mark Miller added a comment - Patch attached.
          Hide
          Mark Miller added a comment -

          I'll commit this shortly.

          Show
          Mark Miller added a comment - I'll commit this shortly.
          Hide
          ASF subversion and git services added a comment -

          Commit 1706681 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1706681 ]

          SOLR-8094: HdfsUpdateLog should not replay buffered documents as a replacement to dropping them.

          Show
          ASF subversion and git services added a comment - Commit 1706681 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1706681 ] SOLR-8094 : HdfsUpdateLog should not replay buffered documents as a replacement to dropping them.
          Hide
          ASF subversion and git services added a comment -

          Commit 1706682 from Mark Miller in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1706682 ]

          SOLR-8094: HdfsUpdateLog should not replay buffered documents as a replacement to dropping them.

          Show
          ASF subversion and git services added a comment - Commit 1706682 from Mark Miller in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1706682 ] SOLR-8094 : HdfsUpdateLog should not replay buffered documents as a replacement to dropping them.

            People

            • Assignee:
              Mark Miller
              Reporter:
              Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development