Solr
  1. Solr
  2. SOLR-8041

SolrVelocityResourceTool .get(key,baseName,locale) ignores locale, uses default

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 5.3
    • Fix Version/s: 5.3.1, 6.0
    • Component/s: contrib - Velocity
    • Labels:
      None

      Description

      A little obscure, this bug. It surfaces when when trying to look up a resource of a different locale than the v.locale controlled locale. Here's an example (using the example/files resource bundles):

            #set($locales = ["en_US","de_DE","fr_FR"])
            #foreach($locale in $locales)
              <li>$locale: $resource.get("find", "resources", $locale)</li>
            #end
      

      It returns "Find" for every item, but should be three different language values returned.

      1. SOLR-8041.patch
        2 kB
        Erik Hatcher

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1702516 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1702516 ]

        SOLR-8041: Fix VelocityResponseWriter's .get(key,baseName,locale) to use specified locale

        Show
        ASF subversion and git services added a comment - Commit 1702516 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1702516 ] SOLR-8041 : Fix VelocityResponseWriter's .get(key,baseName,locale) to use specified locale
        Hide
        ASF subversion and git services added a comment -

        Commit 1702517 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1702517 ]

        SOLR-8041: Fix VelocityResponseWriter's .get(key,baseName,locale) to use specified locale (merged from trunk r1702516)

        Show
        ASF subversion and git services added a comment - Commit 1702517 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1702517 ] SOLR-8041 : Fix VelocityResponseWriter's .get(key,baseName,locale) to use specified locale (merged from trunk r1702516)
        Hide
        Erik Hatcher added a comment -

        I'm hoping this can make it to 5.3.1 Noble Paul - I've committed to branch_5x and trunk with the CHANGES.txt entry in the 5.3.1 section. I'll move it if needed, but hopefully we can just merge over to the 5_3 branch.

        Show
        Erik Hatcher added a comment - I'm hoping this can make it to 5.3.1 Noble Paul - I've committed to branch_5x and trunk with the CHANGES.txt entry in the 5.3.1 section. I'll move it if needed, but hopefully we can just merge over to the 5_3 branch.
        Hide
        ASF subversion and git services added a comment -

        Commit 1702529 from Erik Hatcher in branch 'dev/branches/lucene_solr_5_3'
        [ https://svn.apache.org/r1702529 ]

        SOLR-8041: Fix VelocityResponseWriter's $resource.get(key,baseName,locale) to use specified locale (merged from branch_5x r1702517

        Show
        ASF subversion and git services added a comment - Commit 1702529 from Erik Hatcher in branch 'dev/branches/lucene_solr_5_3' [ https://svn.apache.org/r1702529 ] SOLR-8041 : Fix VelocityResponseWriter's $resource.get(key,baseName,locale) to use specified locale (merged from branch_5x r1702517

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development