Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8015

HdfsLock may fail to close a FileSystem instance if it cannot immediately obtain an index lock.

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 5.5, 6.0
        • Component/s: hdfs
        • Labels:
          None

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          markrmiller@gmail.com Mark Miller added a comment -

          Nope, was not following correctly. On obtain we get the FS for the lock, the lock than closed the FS on release (now close). All good.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Nope, was not following correctly. On obtain we get the FS for the lock, the lock than closed the FS on release (now close). All good.
          Hide
          Permalink
          markrmiller@gmail.com Mark Miller added a comment -

          I found the issue. We create the Filesystem instance, but we have to close it if we don't end up making the Lock instance. That also means we have to create a Filesystem object at the start of each retry.

          Show
          markrmiller@gmail.com Mark Miller added a comment - I found the issue. We create the Filesystem instance, but we have to close it if we don't end up making the Lock instance. That also means we have to create a Filesystem object at the start of each retry.
          Hide
          Permalink
          mdrob Mike Drob added a comment -

          Seems like SOLR-8169 would take care of this indirectly.

          Show
          mdrob Mike Drob added a comment - Seems like SOLR-8169 would take care of this indirectly.
          Hide
          Permalink
          markrmiller@gmail.com Mark Miller added a comment -

          We should still fix this current code. It's fairly simple, I have the code somewhere I think. Forgot that this issue was still open.

          Show
          markrmiller@gmail.com Mark Miller added a comment - We should still fix this current code. It's fairly simple, I have the code somewhere I think. Forgot that this issue was still open.
          Hide
          Permalink
          markrmiller@gmail.com Mark Miller added a comment -

          Patch with change.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Patch with change.
          Hide
          Permalink
          jira-bot ASF subversion and git services added a comment -

          Commit 1720773 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1720773 ]

          SOLR-8015: HdfsLock may fail to close a FileSystem instance if it cannot immediately obtain an index lock.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1720773 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1720773 ] SOLR-8015 : HdfsLock may fail to close a FileSystem instance if it cannot immediately obtain an index lock.
          Hide
          Permalink
          jira-bot ASF subversion and git services added a comment -

          Commit 1720775 from Mark Miller in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1720775 ]

          SOLR-8015: HdfsLock may fail to close a FileSystem instance if it cannot immediately obtain an index lock.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1720775 from Mark Miller in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1720775 ] SOLR-8015 : HdfsLock may fail to close a FileSystem instance if it cannot immediately obtain an index lock.

            People

            • Assignee:
              markrmiller@gmail.com Mark Miller
              Reporter:
              markrmiller@gmail.com Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development