[SOLR-7990] timeAllowed is returning wrong results on the same query submitted with different timeAllowed limits

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.2.1, 5.4, 6.0
• Fix Version/s: 5.3.1
• Assignee: Yonik Seeley
• Reporter: Erick Erickson
• Created: 29/Aug/15 22:23
• Updated: 09/May/16 18:56
• Resolved: 09/Sep/15 15:05

Description

William Bell raised a question on the user's list. The scenario is
> send a query that exceeds timeAllowed
> send another identical query with larger timeAllowed that does NOT time out

The results from the second query are not correct, they reflect the doc count from the first query.

It apparently has to do with filter queries being inappropriately created and re-used. I've attached a test case that illustrates the problem.

There are three tests here.
testFilterSimpleCase shows the problem.

testCacheAssumptions is my hack at what I think the states of the caches should be, but has a bunch of clutter so I'm Ignoring it for now. This should be un-ignored and testFilterSimpleCase removed when there's any fix proposed. The assumptions may not be correct though.

testQueryResults shows what I think is a problem, the second call that does NOT exceed timeAllowed still reports partial results.