Solr
  1. Solr
  2. SOLR-7958

Move TestUtil#randomWhitespace to the test that is sole user

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Followup issue to: LUCENE-6760

      TestUtil#randomWhitespace is only used by org.apache.solr.search.ReturnFieldsTest#testWhitespace()

      After talking with Robert, this method is not useful for Lucene, so we should move it to just this test.

      1. SOLR-7958.patch
        5 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment -

          Patch moving the method (and removing unused static field member in the test)

          Show
          Uwe Schindler added a comment - Patch moving the method (and removing unused static field member in the test)
          Hide
          ASF subversion and git services added a comment -

          Commit 1697262 from Uwe Schindler in branch 'dev/trunk'
          [ https://svn.apache.org/r1697262 ]

          SOLR-7958: Move TestUtil#randomWhitespace to the only Solr test that is using it

          Show
          ASF subversion and git services added a comment - Commit 1697262 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1697262 ] SOLR-7958 : Move TestUtil#randomWhitespace to the only Solr test that is using it
          Hide
          ASF subversion and git services added a comment -

          Commit 1697264 from Uwe Schindler in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1697264 ]

          Merged revision(s) 1697262 from lucene/dev/trunk:
          SOLR-7958: Move TestUtil#randomWhitespace to the only Solr test that is using it

          Show
          ASF subversion and git services added a comment - Commit 1697264 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1697264 ] Merged revision(s) 1697262 from lucene/dev/trunk: SOLR-7958 : Move TestUtil#randomWhitespace to the only Solr test that is using it
          Hide
          Uwe Schindler added a comment -

          Done.

          Show
          Uwe Schindler added a comment - Done.
          Hide
          ASF subversion and git services added a comment -

          Commit 1701816 from Uwe Schindler in branch 'dev/branches/lucene_solr_5_3'
          [ https://svn.apache.org/r1701816 ]

          Backport:
          LUCENE-6760: Prevent test failure in Java 9 b76+
          SOLR-7958: Move TestUtil#randomWhitespace to the only Solr test that is using it
          LUCENE-6760: if the list of whitspace characters changes again in a future JVM, fail fast with a clear error that the test needs corrected – even if jvm assertions are disabled OR we get really lucky with the chars radnomly selected (merge r1698227)

          Show
          ASF subversion and git services added a comment - Commit 1701816 from Uwe Schindler in branch 'dev/branches/lucene_solr_5_3' [ https://svn.apache.org/r1701816 ] Backport: LUCENE-6760 : Prevent test failure in Java 9 b76+ SOLR-7958 : Move TestUtil#randomWhitespace to the only Solr test that is using it LUCENE-6760 : if the list of whitspace characters changes again in a future JVM, fail fast with a clear error that the test needs corrected – even if jvm assertions are disabled OR we get really lucky with the chars radnomly selected (merge r1698227)

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development