Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7930

Comment out trappy references to example docs in elevate.xml files

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.3, 6.0
    • Fix Version/s: 6.2, master (7.0)
    • Component/s: None
    • Labels:
      None

      Description

      What do people think about this? QEV, especially with the default example is trappy when someone defines the <uniqueKey> as something other than a string.

      1. SOLR-7930.patch
        10 kB
        Erick Erickson

        Issue Links

          Activity

          Hide
          dsmiley David Smiley added a comment -

          In which solrconfig.xml? Based on the 3 configsets we have, it doesn't appear there is a problem:

          • "basic": doesn't have QEC.
          • "data_driven_schema_configs": I don't think you'd go modifying the ID of a data driven config? I
          • "sample_techproducts_configs": This is no longer the default template many people choose; it's now just an example. I don't think we should change it for this.

          In the end, what may be needed is a clearer error message should this mistake be made.

          Show
          dsmiley David Smiley added a comment - In which solrconfig.xml? Based on the 3 configsets we have, it doesn't appear there is a problem: "basic": doesn't have QEC. "data_driven_schema_configs": I don't think you'd go modifying the ID of a data driven config? I "sample_techproducts_configs": This is no longer the default template many people choose; it's now just an example. I don't think we should change it for this. In the end, what may be needed is a clearer error message should this mistake be made.
          Hide
          erickerickson Erick Erickson added a comment -

          OK, I'm trying to clear out some backlog and came back to this. I think the right thing to do here is just comment out all of the entries in the elevate.xml config files.

          The trappy bit is that a user whose never even heard of QEV changes the <uniqueKey> to something like "long" and suddenly can't load the core or create a collection. Because we've included an example elevations that are only relevant to the sample techproducts docs.

          If someone intentionally changes the QEV component then I think the stack trace is sufficient since it makes sense in that context. And at least they're working with QEV so have incentive to look.

          I'll check this in tomorrow sometime unless there are objections.

          Show
          erickerickson Erick Erickson added a comment - OK, I'm trying to clear out some backlog and came back to this. I think the right thing to do here is just comment out all of the entries in the elevate.xml config files. The trappy bit is that a user whose never even heard of QEV changes the <uniqueKey> to something like "long" and suddenly can't load the core or create a collection. Because we've included an example elevations that are only relevant to the sample techproducts docs. If someone intentionally changes the QEV component then I think the stack trace is sufficient since it makes sense in that context. And at least they're working with QEV so have incentive to look. I'll check this in tomorrow sometime unless there are objections.
          Hide
          erickerickson Erick Erickson added a comment -

          BAH. I mis-typed the JIRA. The hashes for this checkin were:

          master: db295440a6a9aa0d43a2611c81331feda50a5834
          6x: 6a278333f2836d47c189ac95d2af9d465f22c676

          Show
          erickerickson Erick Erickson added a comment - BAH. I mis-typed the JIRA. The hashes for this checkin were: master: db295440a6a9aa0d43a2611c81331feda50a5834 6x: 6a278333f2836d47c189ac95d2af9d465f22c676
          Hide
          mikemccand Michael McCandless added a comment -

          Bulk close resolved issues after 6.2.0 release.

          Show
          mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

            People

            • Assignee:
              erickerickson Erick Erickson
              Reporter:
              erickerickson Erick Erickson
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development