Solr
  1. Solr
  2. SOLR-7908

SegmentsInfoRequestHandler gets a ref counted IndexWriter and does not properly release it.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.1
    • Fix Version/s: 5.3, 6.0
    • Component/s: web gui
    • Labels:
      None
    1. SOLR-7908.patch
      2 kB
      Shalin Shekhar Mangar

      Activity

      Hide
      Mark Miller added a comment -
        private IndexWriter getIndexWriter(SolrQueryRequest req) throws IOException {
          return req.getCore().getSolrCoreState().getIndexWriter(req.getCore()).get();
        }
      

      This is not right.

      Show
      Mark Miller added a comment - private IndexWriter getIndexWriter(SolrQueryRequest req) throws IOException { return req.getCore().getSolrCoreState().getIndexWriter(req.getCore()).get(); } This is not right.
      Hide
      Varun Thacker added a comment -

      We should fix this for 5.3 right?

      Show
      Varun Thacker added a comment - We should fix this for 5.3 right?
      Hide
      Shalin Shekhar Mangar added a comment -

      Yes, I'll fix.

      Show
      Shalin Shekhar Mangar added a comment - Yes, I'll fix.
      Hide
      Shalin Shekhar Mangar added a comment -

      Trivial fix attached.

      Show
      Shalin Shekhar Mangar added a comment - Trivial fix attached.
      Hide
      ASF subversion and git services added a comment -

      Commit 1695069 from shalin@apache.org in branch 'dev/trunk'
      [ https://svn.apache.org/r1695069 ]

      SOLR-7908: SegmentsInfoRequestHandler gets a ref counted IndexWriter and does not properly release it

      Show
      ASF subversion and git services added a comment - Commit 1695069 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1695069 ] SOLR-7908 : SegmentsInfoRequestHandler gets a ref counted IndexWriter and does not properly release it
      Hide
      ASF subversion and git services added a comment -

      Commit 1695072 from shalin@apache.org in branch 'dev/branches/branch_5x'
      [ https://svn.apache.org/r1695072 ]

      SOLR-7908: SegmentsInfoRequestHandler gets a ref counted IndexWriter and does not properly release it

      Show
      ASF subversion and git services added a comment - Commit 1695072 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1695072 ] SOLR-7908 : SegmentsInfoRequestHandler gets a ref counted IndexWriter and does not properly release it
      Hide
      ASF subversion and git services added a comment -

      Commit 1695087 from shalin@apache.org in branch 'dev/branches/lucene_solr_5_3'
      [ https://svn.apache.org/r1695087 ]

      SOLR-7908: SegmentsInfoRequestHandler gets a ref counted IndexWriter and does not properly release it

      Show
      ASF subversion and git services added a comment - Commit 1695087 from shalin@apache.org in branch 'dev/branches/lucene_solr_5_3' [ https://svn.apache.org/r1695087 ] SOLR-7908 : SegmentsInfoRequestHandler gets a ref counted IndexWriter and does not properly release it
      Hide
      Shalin Shekhar Mangar added a comment -

      Thanks for catching this, Mark!

      Show
      Shalin Shekhar Mangar added a comment - Thanks for catching this, Mark!
      Hide
      Shalin Shekhar Mangar added a comment -

      Bulk close for 5.3.0 release

      Show
      Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

        People

        • Assignee:
          Shalin Shekhar Mangar
          Reporter:
          Mark Miller
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development