Solr
  1. Solr
  2. SOLR-7863

Lowercase the CLUSTERPROP command in ZkCLI for consistency

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.2.1
    • Fix Version/s: 5.3, 6.0
    • Component/s: scripts and tools
    • Labels:

      Description

      The examples for the zkcli.sh command looks like this

      Examples:
      zkcli.sh -zkhost localhost:9983 -cmd bootstrap -solrhome /opt/solr
      zkcli.sh -zkhost localhost:9983 -cmd upconfig -confdir /opt/solr/collection1/conf -confname myconf
      zkcli.sh -zkhost localhost:9983 -cmd downconfig -confdir /opt/solr/collection1/conf -confname myconf
      zkcli.sh -zkhost localhost:9983 -cmd linkconfig -collection collection1 -confname myconf
      zkcli.sh -zkhost localhost:9983 -cmd makepath /apache/solr
      zkcli.sh -zkhost localhost:9983 -cmd put /solr.conf 'conf data'
      zkcli.sh -zkhost localhost:9983 -cmd putfile /solr.xml /User/myuser/solr/solr.xml
      zkcli.sh -zkhost localhost:9983 -cmd get /solr.xml
      zkcli.sh -zkhost localhost:9983 -cmd getfile /solr.xml solr.xml.file
      zkcli.sh -zkhost localhost:9983 -cmd clear /solr
      zkcli.sh -zkhost localhost:9983 -cmd list
      zkcli.sh -zkhost localhost:9983 -cmd CLUSTERPROP -name urlScheme -val https
      

      It is inconsistent that CLUSTERPROP is uppercase.

      1. SOLR-7863.patch
        8 kB
        Jan Høydahl
      2. SOLR-7863.patch
        2 kB
        Jan Høydahl

        Activity

        Hide
        Jan Høydahl added a comment -

        Also, if an unknown -cmd is issued, the tool just exits without any message/error.

        Show
        Jan Høydahl added a comment - Also, if an unknown -cmd is issued, the tool just exits without any message/error.
        Hide
        Jan Høydahl added a comment -

        I'm attaching a patch that lowercases the clusterprop cmd but accepts both upper and lowercase variants for back compat. Also adds error msg for unknown cmd.

        Show
        Jan Høydahl added a comment - I'm attaching a patch that lowercases the clusterprop cmd but accepts both upper and lowercase variants for back compat. Also adds error msg for unknown cmd.
        Hide
        Jan Høydahl added a comment -

        New patch, making all -cmd case insensitive, so you can write -cmd LIST if you wish. Will commit this to trunk and 5.x shortly.

        Show
        Jan Høydahl added a comment - New patch, making all -cmd case insensitive, so you can write -cmd LIST if you wish. Will commit this to trunk and 5.x shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1693887 from janhoy@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1693887 ]

        SOLR-7863: Lowercase the CLUSTERPROP command in ZkCLI for consistency, print error for unknown cmd (janhoy)

        Show
        ASF subversion and git services added a comment - Commit 1693887 from janhoy@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1693887 ] SOLR-7863 : Lowercase the CLUSTERPROP command in ZkCLI for consistency, print error for unknown cmd (janhoy)
        Hide
        ASF subversion and git services added a comment -

        Commit 1693894 from janhoy@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1693894 ]

        SOLR-7863: Lowercase the CLUSTERPROP command in ZkCLI for consistency, print error for unknown cmd (backport)

        Show
        ASF subversion and git services added a comment - Commit 1693894 from janhoy@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1693894 ] SOLR-7863 : Lowercase the CLUSTERPROP command in ZkCLI for consistency, print error for unknown cmd (backport)
        Hide
        Jan Høydahl added a comment -

        Also documented the clusterprop cmd in RefGuide

        Show
        Jan Høydahl added a comment - Also documented the clusterprop cmd in RefGuide
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Jan Høydahl
            Reporter:
            Jan Høydahl
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development