Solr
  1. Solr
  2. SOLR-783

DIH - Better support for handling delta-imports per entity

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Labels:
      None
    • Environment:

      Linux, OpenSolaris

      Description

      Currently there is no way to perform a delta import per entity because $

      {dataimporter.last_index_time}

      really represents the entire delta-import for all entities and is only a single dataimport.properties file.

      A delta-import w/ dataimport?command=delta-import&entity=a and dataimport?command=delta-import&entity=b should result in:

      $

      {dataimporter.[name of entity].last_index_time}
      ${dataimporter.[name of entity].last_index_time}

      I do this now because I have a single multicore representing different docs coming from different entities.

      1. SOLR-783.patch
        8 kB
        Shalin Shekhar Mangar
      2. SOLR-783.patch
        7 kB
        Noble Paul

        Activity

        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4
        Hide
        Shalin Shekhar Mangar added a comment -

        The above change was necessary during full-imports too.

        Committed revision 751043.

        Show
        Shalin Shekhar Mangar added a comment - The above change was necessary during full-imports too. Committed revision 751043.
        Hide
        Shalin Shekhar Mangar added a comment -

        When commit=false, the last_index_time is not set which leads to a NPE during date formatting from DocBuilder. I committed a fix to set the last_index_time to the current date. This fixes the issue but has no affect because the new last_index_time is not written to dataimport.properties if commit=false is specified.

        Committed revision 747792.

        Show
        Shalin Shekhar Mangar added a comment - When commit=false, the last_index_time is not set which leads to a NPE during date formatting from DocBuilder. I committed a fix to set the last_index_time to the current date. This fixes the issue but has no affect because the new last_index_time is not written to dataimport.properties if commit=false is specified. Committed revision 747792.
        Shalin Shekhar Mangar made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 746189.

        Thanks Jon and Noble!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 746189. Thanks Jon and Noble!
        Shalin Shekhar Mangar made changes -
        Attachment SOLR-783.patch [ 12400588 ]
        Hide
        Shalin Shekhar Mangar added a comment -

        Patch updated to trunk. I changed the code to write the last index time after commit completes.

        I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Patch updated to trunk. I changed the code to write the last index time after commit completes. I'll commit this shortly.
        Noble Paul made changes -
        Attachment SOLR-783.patch [ 12400478 ]
        Shalin Shekhar Mangar made changes -
        Assignee Shalin Shekhar Mangar [ shalinmangar ]
        Shalin Shekhar Mangar made changes -
        Field Original Value New Value
        Fix Version/s 1.4 [ 12313351 ]
        Jon Baer created issue -

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Jon Baer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development