Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      A lot of unnecessary code was introduced in DIH to make it work both 1.2 and 1.3. Now 1.3 is out we can clean it up

      1. evaluatorcleanup.patch
        9 kB
        Noble Paul
      2. SOLR-782.patch
        14 kB
        Noble Paul
      3. SOLR-782.patch
        17 kB
        Shalin Shekhar Mangar
      4. SOLR-782.patch
        11 kB
        Shalin Shekhar Mangar
      5. SOLR-782.patch
        9 kB
        Noble Paul

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Not a bug, therefore marking this for 1.4

        Show
        Shalin Shekhar Mangar added a comment - Not a bug, therefore marking this for 1.4
        Hide
        Shalin Shekhar Mangar added a comment -

        Updating patch to trunk. I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Updating patch to trunk. I'll commit this shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 706542.

        Thanks Noble!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 706542. Thanks Noble!
        Hide
        Noble Paul added a comment -

        evaluators loaded lazily

        Show
        Noble Paul added a comment - evaluators loaded lazily
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 712635.

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 712635.
        Hide
        Shalin Shekhar Mangar added a comment -

        Another round of cleanup:

        1. Removed multiple document nodes in the configuration xml. They were not used anyway.
        2. Removed 'default' variables. This was a feature which was never documented or advertised on the mailing list. It can very easily be replaced with the request handlers' built-in support for 'default' request parameters.

        I will commit in a day or two.

        Show
        Shalin Shekhar Mangar added a comment - Another round of cleanup: Removed multiple document nodes in the configuration xml. They were not used anyway. Removed 'default' variables. This was a feature which was never documented or advertised on the mailing list. It can very easily be replaced with the request handlers' built-in support for 'default' request parameters. I will commit in a day or two.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 730055.

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 730055.
        Hide
        Brian Mansell added a comment -

        Shalin -

        The multiple document nodes in data-config.xml files allows users to break up their entities into different document structures within the same Solr index, correct?

        Was the primary purpose behind dropping this feature to reduce scope or are there other reasons for not including it in the 1.3 release?

        I should note that the functionality in the Data Import Handler with Solr 1.3 is a huge time saver. Thanks for your efforts on this feature.

        thanks,
        --bemansell

        Show
        Brian Mansell added a comment - Shalin - The multiple document nodes in data-config.xml files allows users to break up their entities into different document structures within the same Solr index, correct? Was the primary purpose behind dropping this feature to reduce scope or are there other reasons for not including it in the 1.3 release? I should note that the functionality in the Data Import Handler with Solr 1.3 is a huge time saver. Thanks for your efforts on this feature. thanks, --bemansell
        Hide
        Noble Paul added a comment -

        multiple <document> were never supported by DIH .

        Whatever can be achieved w/ multiple <document> can be achieved w/ multiple root-entities . Please let me know if there is a usecase that is not met by that and that is solved by multiple <document>

        Show
        Noble Paul added a comment - multiple <document> were never supported by DIH . Whatever can be achieved w/ multiple <document> can be achieved w/ multiple root-entities . Please let me know if there is a usecase that is not met by that and that is solved by multiple <document>
        Hide
        Noble Paul added a comment -

        script should be exposed as an API

        Show
        Noble Paul added a comment - script should be exposed as an API
        Hide
        Shalin Shekhar Mangar added a comment -

        Let us create a new issue for the script cleanup as it introduces new API methods in Context.

        Show
        Shalin Shekhar Mangar added a comment - Let us create a new issue for the script cleanup as it introduces new API methods in Context.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development