[SOLR-7819] ZkController.ensureReplicaInLeaderInitiatedRecovery does not respect retryOnConnLoss

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.2, 5.2.1
• Fix Version/s: 5.4, 6.0
• Component/s: SolrCloud
• Labels: Jepsen
• Assignee: Shalin Shekhar Mangar
• Reporter: Shalin Shekhar Mangar
• Created: 22/Jul/15 11:44
• Updated: 09/May/16 18:51
• Resolved: 10/Sep/15 11:09

Description

SOLR-7245 added a retryOnConnLoss parameter to ZkController.ensureReplicaInLeaderInitiatedRecovery so that indexing threads do not hang during a partition on ZK operations. However, some of those changes were unintentionally reverted by SOLR-7336 in 5.2.

I found this while running Jepsen tests on 5.2.1 where a hung update managed to put a leader into a 'down' state (I'm still investigating and will open a separate issue about this problem).

Issue Links

• is related to: SOLR-7336 Add State enum to Replica
• is related to: SOLR-7245 Temporary ZK election or connection loss should not stall indexing due to LIR