[SOLR-7781] FieldFaceting BytesRef reuse bug

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1
• Fix Version/s: 5.3
• Component/s: Facet Module
• Assignee: Yonik Seeley
• Reporter: Yonik Seeley
• Created: 12/Jul/15 20:36
• Updated: 26/Aug/15 13:06
• Resolved: 12/Jul/15 22:45

Description

FieldFaceting on a string field has

new TermQuery( new Term(field, bytesRef.clone() ) )

The bytesRef needs to be deep copied (and clone() only implements a shallow copy).
This causes to the query inserted into the filter cache to be changed after the fact, and causes both cache misses and even cache growth way past configured limits due to failures to remove old cache items (SOLR-7777).