Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 5.3
    • Component/s: Facet Module
    • Labels:
      None

      Description

      FieldFaceting on a string field has

      new TermQuery( new Term(field, bytesRef.clone() ) )
      

      The bytesRef needs to be deep copied (and clone() only implements a shallow copy).
      This causes to the query inserted into the filter cache to be changed after the fact, and causes both cache misses and even cache growth way past configured limits due to failures to remove old cache items (SOLR-7777).

      1. SOLR-7781.patch
        1.0 kB
        Yonik Seeley

        Activity

        Hide
        Yonik Seeley added a comment -

        Here's the patch.

        Show
        Yonik Seeley added a comment - Here's the patch.
        Hide
        ASF subversion and git services added a comment -

        Commit 1690541 from Yonik Seeley in branch 'dev/trunk'
        [ https://svn.apache.org/r1690541 ]

        SOLR-7781: change FacetField BytesRef shallow clone to deep clone

        Show
        ASF subversion and git services added a comment - Commit 1690541 from Yonik Seeley in branch 'dev/trunk' [ https://svn.apache.org/r1690541 ] SOLR-7781 : change FacetField BytesRef shallow clone to deep clone
        Hide
        ASF subversion and git services added a comment -

        Commit 1690542 from Yonik Seeley in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1690542 ]

        SOLR-7781: change FacetField BytesRef shallow clone to deep clone

        Show
        ASF subversion and git services added a comment - Commit 1690542 from Yonik Seeley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1690542 ] SOLR-7781 : change FacetField BytesRef shallow clone to deep clone
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Yonik Seeley
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development