Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6234 Scoring modes for query time join
  3. SOLR-7775

support SolrCloud collection as fromIndex param in query-time join

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4
    • Component/s: query parsers
    • Labels:
      None

      Description

      it's allusion to SOLR-4905, will be addressed right after SOLR-6234

      1. SOLR-7775.patch
        19 kB
        Andrei Beliakov
      2. SOLR-7775.patch
        20 kB
        Andrei Beliakov

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1702138 from mkhl@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1702138 ]

          SOLR-8026: ignoring score values asserts on cloud score join (SOLR-7775)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1702138 from mkhl@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1702138 ] SOLR-8026 : ignoring score values asserts on cloud score join ( SOLR-7775 )
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          I found a reproducible test failure (on trunk) which I think is related to this commit:

          ant test  -Dtestcase=DistribJoinFromCollectionTest -Dtests.method=test -Dtests.seed=F9912CAACBE27737 -Dtests.slow=true -Dtests.locale=lt_LT -Dtests.timezone=America/Moncton -Dtests.asserts=true -Dtests.file.encoding=UTF-8
          
          Show
          shalinmangar Shalin Shekhar Mangar added a comment - I found a reproducible test failure (on trunk) which I think is related to this commit: ant test -Dtestcase=DistribJoinFromCollectionTest -Dtests.method=test -Dtests.seed=F9912CAACBE27737 -Dtests.slow= true -Dtests.locale=lt_LT -Dtests.timezone=America/Moncton -Dtests.asserts= true -Dtests.file.encoding=UTF-8
          Show
          mkhludnev Mikhail Khludnev added a comment - updated ref guide https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=32604257&selectedPageVersions=55&selectedPageVersions=56
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1697167 from mkhl@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1697167 ]

          SOLR-7775:

          {!join score=.. fromIndex=...}

          supports single-sharded replicated SolrCloud collection

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1697167 from mkhl@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1697167 ] SOLR-7775 : {!join score=.. fromIndex=...} supports single-sharded replicated SolrCloud collection
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1697157 from mkhl@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1697157 ]

          SOLR-7775: {!join score=.. fromIndex=...} supports single-sharded replicated SolrCloudollection

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1697157 from mkhl@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1697157 ] SOLR-7775 : {!join score=.. fromIndex=...} supports single-sharded replicated SolrCloudollection
          Hide
          thelabdude Timothy Potter added a comment -

          Sorry for the delay Mikhail Khludnev on getting back to you on this ... patch looks good! +1 for commit

          Show
          thelabdude Timothy Potter added a comment - Sorry for the delay Mikhail Khludnev on getting back to you on this ... patch looks good! +1 for commit
          Hide
          mkhludnev Mikhail Khludnev added a comment -

          Timothy Potter would you like to skim through? For me the patch is ready, I'd like to rename a couple of methods and update Javadoc.

          Show
          mkhludnev Mikhail Khludnev added a comment - Timothy Potter would you like to skim through? For me the patch is ready, I'd like to rename a couple of methods and update Javadoc.
          Hide
          abeliakov Andrei Beliakov added a comment -

          Here is the patch. The code which obtains core name was extracted into ScoreJoinQParserPlugin. It might not be the best approach, I'm open to your suggestions. Test coverage is provided in DistibJoinFromCollectionTest.

          Show
          abeliakov Andrei Beliakov added a comment - Here is the patch. The code which obtains core name was extracted into ScoreJoinQParserPlugin. It might not be the best approach, I'm open to your suggestions. Test coverage is provided in DistibJoinFromCollectionTest.

            People

            • Assignee:
              mkhludnev Mikhail Khludnev
              Reporter:
              mkhludnev Mikhail Khludnev
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development