Solr
  1. Solr
  2. SOLR-7774

BasicDistributedZkTest.test (commitWithin did not work on node) failures

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Seeing this now and again in our jenkins instance and also on the dev list's jenkins emails e.g. [JENKINS] Lucene-Solr-trunk-Linux (32bit/jdk1.8.0_60-ea-b21) - Build # 13356 - Failure! - gibhub pull request with proposed test changes to follow.

      1. SOLR-7774.patch
        2 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          ASF GitHub Bot added a comment -

          GitHub user cpoerschke opened a pull request:

          https://github.com/apache/lucene-solr/pull/188

          BasicDistributedZkTest.test (commitWithin did not work on node) failures

          for https://issues.apache.org/jira/i#browse/SOLR-7774

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bloomberg/lucene-solr trunk-BasicDistributedZkTest-test

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/188.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #188


          commit 7aca8991c7e8ca25bf63bb256cab7a8846f9307b
          Author: Christine Poerschke <cpoerschke@bloomberg.net>
          Date: 2015-07-09T18:27:59Z

          SOLR-????: BasicDistributedZkTest.test (commitWithin did not work on node) failures

          BasicDistributedZkTest.test now checks document counts for each node before the commitWithin document addition, this is to ensure that at baseline all nodes have the same document count.

          Also revised logic to avoid possible scenario of the queried-via-cloudClient node having 'quickly' committed the additional document and other queried-via-SolrClient nodes being a little 'slower' and thus being 'commitWithin did not work on node' failed (within the 45s overall timeout).


          Show
          ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/188 BasicDistributedZkTest.test (commitWithin did not work on node) failures for https://issues.apache.org/jira/i#browse/SOLR-7774 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-BasicDistributedZkTest-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/188.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #188 commit 7aca8991c7e8ca25bf63bb256cab7a8846f9307b Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2015-07-09T18:27:59Z SOLR-????: BasicDistributedZkTest.test (commitWithin did not work on node) failures BasicDistributedZkTest.test now checks document counts for each node before the commitWithin document addition, this is to ensure that at baseline all nodes have the same document count. Also revised logic to avoid possible scenario of the queried-via-cloudClient node having 'quickly' committed the additional document and other queried-via-SolrClient nodes being a little 'slower' and thus being 'commitWithin did not work on node' failed (within the 45s overall timeout).
          Hide
          Shalin Shekhar Mangar added a comment -

          This looks good Christine, can you please commit this fix?

          Show
          Shalin Shekhar Mangar added a comment - This looks good Christine, can you please commit this fix?
          Hide
          Christine Poerschke added a comment -

          rebased patch of the pull request and resolved merge conflict

          Show
          Christine Poerschke added a comment - rebased patch of the pull request and resolved merge conflict
          Hide
          ASF subversion and git services added a comment -

          Commit 1718364 from Christine Poerschke in branch 'dev/trunk'
          [ https://svn.apache.org/r1718364 ]

          SOLR-7774: revise BasicDistributedZkTest.test logic w.r.t. 'commitWithin did not work on some nodes'

          Show
          ASF subversion and git services added a comment - Commit 1718364 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1718364 ] SOLR-7774 : revise BasicDistributedZkTest.test logic w.r.t. 'commitWithin did not work on some nodes'
          Hide
          ASF subversion and git services added a comment -

          Commit 1718389 from Christine Poerschke in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1718389 ]

          SOLR-7774: revise BasicDistributedZkTest.test logic w.r.t. 'commitWithin did not work on some nodes' (merge in revision 1718364 from trunk)

          Show
          ASF subversion and git services added a comment - Commit 1718389 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1718389 ] SOLR-7774 : revise BasicDistributedZkTest.test logic w.r.t. 'commitWithin did not work on some nodes' (merge in revision 1718364 from trunk)
          Hide
          Christine Poerschke added a comment -

          Thanks for the review Shalin. Change now committed to both trunk and branch_5x.

          Show
          Christine Poerschke added a comment - Thanks for the review Shalin. Change now committed to both trunk and branch_5x.

            People

            • Assignee:
              Christine Poerschke
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development