Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      We should have a standard mechanism which security plugins can use to edit/reload etc for various plugins.
      This will involve solr watching the /security.json and giving callbacks to the plugins. It wil also create standard end points for Rest-like APIs for each plugin. Each plugin will be able to define the payload, verify it, modify the config etc

      1. SOLR-7757.patch
        63 kB
        Anshum Gupta

        Issue Links

          Activity

          Hide
          Ishan Chattopadhyaya added a comment -
          Show
          Ishan Chattopadhyaya added a comment - The latest patch for this is added to SOLR-7692 , here: https://issues.apache.org/jira/secure/attachment/12747513/SOLR-7757.patch
          Hide
          Anshum Gupta added a comment -

          Moving the last patch from SOLR-7692 that was meant to this issue here.

          Show
          Anshum Gupta added a comment - Moving the last patch from SOLR-7692 that was meant to this issue here.
          Hide
          ASF subversion and git services added a comment -

          Commit 1694552 from Noble Paul in branch 'dev/trunk'
          [ https://svn.apache.org/r1694552 ]

          SOLR-7757: Improved security framework where security components can be edited/reloaded, Solr now watches /security.json. Components can choose to make their configs editable

          Show
          ASF subversion and git services added a comment - Commit 1694552 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1694552 ] SOLR-7757 : Improved security framework where security components can be edited/reloaded, Solr now watches /security.json. Components can choose to make their configs editable
          Hide
          ASF subversion and git services added a comment -

          Commit 1694556 from Noble Paul in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1694556 ]

          SOLR-7757: Improved security framework where security components can be edited/reloaded, Solr now watches /security.json. Components can choose to make their configs editable

          Show
          ASF subversion and git services added a comment - Commit 1694556 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1694556 ] SOLR-7757 : Improved security framework where security components can be edited/reloaded, Solr now watches /security.json. Components can choose to make their configs editable
          Hide
          ASF subversion and git services added a comment -

          Commit 1694564 from Noble Paul in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1694564 ]

          SOLR-7757: Pair is not available in java 7

          Show
          ASF subversion and git services added a comment - Commit 1694564 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1694564 ] SOLR-7757 : Pair is not available in java 7
          Hide
          ASF subversion and git services added a comment -

          Commit 1694565 from Noble Paul in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1694565 ]

          SOLR-7757: Pair is not available in java 7

          Show
          ASF subversion and git services added a comment - Commit 1694565 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1694565 ] SOLR-7757 : Pair is not available in java 7
          Hide
          ASF subversion and git services added a comment -

          Commit 1694566 from Noble Paul in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1694566 ]

          SOLR-7757: Pair is not available in java 7

          Show
          ASF subversion and git services added a comment - Commit 1694566 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1694566 ] SOLR-7757 : Pair is not available in java 7
          Hide
          ASF subversion and git services added a comment -

          Commit 1694864 from Noble Paul in branch 'dev/branches/lucene_solr_5_3'
          [ https://svn.apache.org/r1694864 ]

          SOLR-7757: Improved security framework where security components can be edited/reloaded, Solr now watches /security.json. Components can choose to make their config editable, SOLR-7838: An authorizationPlugin interface where the access control rules are stored/managed in ZooKeeper , SOLR-7837: An AuthenticationPlugin which implements the HTTP BasicAuth protocol and stores credentials securely in ZooKeeper

          Show
          ASF subversion and git services added a comment - Commit 1694864 from Noble Paul in branch 'dev/branches/lucene_solr_5_3' [ https://svn.apache.org/r1694864 ] SOLR-7757 : Improved security framework where security components can be edited/reloaded, Solr now watches /security.json. Components can choose to make their config editable, SOLR-7838 : An authorizationPlugin interface where the access control rules are stored/managed in ZooKeeper , SOLR-7837 : An AuthenticationPlugin which implements the HTTP BasicAuth protocol and stores credentials securely in ZooKeeper
          Hide
          Mark Miller added a comment -

          Did this break the 6x build? I can't compile due to a Pair compilation issue. A fresh checkout (and my existing checkouts) cannot find import javafx.util.Pair;

          Show
          Mark Miller added a comment - Did this break the 6x build? I can't compile due to a Pair compilation issue. A fresh checkout (and my existing checkouts) cannot find import javafx.util.Pair;
          Hide
          Mark Miller added a comment -

          -1 on that random general Pair class in the middle of that ZkStateReader class by the way.

          Show
          Mark Miller added a comment - -1 on that random general Pair class in the middle of that ZkStateReader class by the way.
          Hide
          Shalin Shekhar Mangar added a comment -

          Nope, the build is fine.

          Show
          Shalin Shekhar Mangar added a comment - Nope, the build is fine.
          Hide
          Mark Miller added a comment -

          Then why is broken here on multiple machines.

          Show
          Mark Miller added a comment - Then why is broken here on multiple machines.
          Hide
          Mark Miller added a comment -

          In any case, I've got to make an official veto on the 5x lazy Pair class.

          And this issue is open as far as I'm concerned until I learn why my current checkouts on two machines and a fresh checkout are not finding that import.

          Show
          Mark Miller added a comment - In any case, I've got to make an official veto on the 5x lazy Pair class. And this issue is open as far as I'm concerned until I learn why my current checkouts on two machines and a fresh checkout are not finding that import.
          Hide
          Noble Paul added a comment -

          I built it on trunk where Pair was available. It is available in java 8.

          branch 5x compilation was failing. So I just added the class to make this work

          Yes, we will remove the Pair class

          Show
          Noble Paul added a comment - I built it on trunk where Pair was available. It is available in java 8. branch 5x compilation was failing. So I just added the class to make this work Yes, we will remove the Pair class
          Hide
          Noble Paul added a comment -

          I don't see any jenkins build broken

          Show
          Noble Paul added a comment - I don't see any jenkins build broken
          Hide
          Shalin Shekhar Mangar added a comment -

          Can you be more specific? I can compile and run tests on trunk just fine. The last trunk build on policeman jenkins and Apache jenkins also have succeeded.

          Show
          Shalin Shekhar Mangar added a comment - Can you be more specific? I can compile and run tests on trunk just fine. The last trunk build on policeman jenkins and Apache jenkins also have succeeded.
          Hide
          Mark Miller added a comment - - edited

          Anyway, I have JDK 8, I have multiple envs, and multiple compilers (eclipse jdk8 support) that are not finding this class.

          Obviously, this javafx package has some issues. Some quick searches show people complaining that javafx is not on their JDK 8 classpath. This is silly for such a simple class that we popped into 5x anyway. This class should be in a general util folder and in it's own class file.

          Show
          Mark Miller added a comment - - edited Anyway, I have JDK 8, I have multiple envs, and multiple compilers (eclipse jdk8 support) that are not finding this class. Obviously, this javafx package has some issues. Some quick searches show people complaining that javafx is not on their JDK 8 classpath. This is silly for such a simple class that we popped into 5x anyway. This class should be in a general util folder and in it's own class file.
          Hide
          Mark Miller added a comment -

          I can make this work by installing a new package. Let's stay out of jfxrt.jar. I'll make this Pair class a Solr Util class.

          Show
          Mark Miller added a comment - I can make this work by installing a new package. Let's stay out of jfxrt.jar. I'll make this Pair class a Solr Util class.
          Hide
          ASF subversion and git services added a comment -

          Commit 1695075 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1695075 ]

          SOLR-7757: Don't use pair from jfxrt.jar - this library is optional in some OS's.

          Show
          ASF subversion and git services added a comment - Commit 1695075 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1695075 ] SOLR-7757 : Don't use pair from jfxrt.jar - this library is optional in some OS's.
          Hide
          ASF subversion and git services added a comment -

          Commit 1695084 from Mark Miller in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1695084 ]

          SOLR-7757: Take random public static Pair class out of ZkStateReader and move it to a Util location.

          Show
          ASF subversion and git services added a comment - Commit 1695084 from Mark Miller in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1695084 ] SOLR-7757 : Take random public static Pair class out of ZkStateReader and move it to a Util location.
          Hide
          Noble Paul added a comment -

          this must go into 5.3 branch as well

          Show
          Noble Paul added a comment - this must go into 5.3 branch as well
          Hide
          ASF subversion and git services added a comment -

          Commit 1695168 from Mark Miller in branch 'dev/branches/lucene_solr_5_3'
          [ https://svn.apache.org/r1695168 ]

          SOLR-7757: Take random public static Pair class out of ZkStateReader and move it to a Util location.

          Show
          ASF subversion and git services added a comment - Commit 1695168 from Mark Miller in branch 'dev/branches/lucene_solr_5_3' [ https://svn.apache.org/r1695168 ] SOLR-7757 : Take random public static Pair class out of ZkStateReader and move it to a Util location.
          Hide
          Shalin Shekhar Mangar added a comment -

          Bulk close for 5.3.0 release

          Show
          Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release
          Hide
          Mark Miller added a comment -

          Looks like this broke something: SOLR-7988 LukeRequest on default path is broken with CloudSolrClient

          Show
          Mark Miller added a comment - Looks like this broke something: SOLR-7988 LukeRequest on default path is broken with CloudSolrClient

            People

            • Assignee:
              Noble Paul
              Reporter:
              Noble Paul
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development