Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7741

SolrIndexerConfig.toMap missing fields

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None

      Description

      From the mailing list:

      Mike Drob wrote:

      I was looking through code for unrelated reasons and this line stuck out to me:

      https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L180

      if(mergeSchedulerInfo != null) m.put("mergeScheduler",mergeSchedulerInfo.toMap()); if(mergePolicyInfo != null) m.put("mergeScheduler",mergePolicyInfo.toMap());

      Are they both supposed to be using the "mergeScheduler" key? If not, happy to open a JIRA and provide the one-line patch.

      Christine Poerschke wrote:

      Follow-on question, also re: SolrIndexConfig's toMap method. The constructor reads "/mergedSegmentWarmer" and "/infoStream" and "/infoStream/@file" elements but the toMap method does not write them.

      Would that be intended or is it maybe an unintended omission? If intended would be great to have a comment in toMap to clarify why/which elements are skipped, so that if/when a new element is added its easier to determine if toMap should write the new element also.

        Attachments

        1. SOLR-7741.patch
          6 kB
          Christine Poerschke
        2. SOLR-7741.patch
          4 kB
          Mike Drob

          Issue Links

            Activity

              People

              • Assignee:
                andyetitmoves Ramkumar Aiyengar
                Reporter:
                mdrob Mike Drob
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: