[SOLR-7741] SolrIndexerConfig.toMap missing fields

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.0
• Fix Version/s: 5.3
• Assignee: Ramkumar Aiyengar
• Reporter: Mike Drob
• Created: 30/Jun/15 21:15
• Updated: 09/May/16 18:46
• Resolved: 03/Jul/15 16:02

Description

From the mailing list:

Mike Drob wrote:

I was looking through code for unrelated reasons and this line stuck out to me:

https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L180

if(mergeSchedulerInfo != null) m.put("mergeScheduler",mergeSchedulerInfo.toMap()); if(mergePolicyInfo != null) m.put("mergeScheduler",mergePolicyInfo.toMap());

Are they both supposed to be using the "mergeScheduler" key? If not, happy to open a JIRA and provide the one-line patch.

Christine Poerschke wrote:

Follow-on question, also re: SolrIndexConfig's toMap method. The constructor reads "/mergedSegmentWarmer" and "/infoStream" and "/infoStream/@file" elements but the toMap method does not write them.

Would that be intended or is it maybe an unintended omission? If intended would be great to have a comment in toMap to clarify why/which elements are skipped, so that if/when a new element is added its easier to determine if toMap should write the new element also.

Issue Links

• is required by: SOLR-7750 change TestConfig.testDefaults to cover all SolrIndexConfig fields