Solr
  1. Solr
  2. SOLR-771

CoreAdminHandler STATUS should display 'normalized' paths

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      From the mailing list...

      On Sun, Sep 14, 2008 at 6:45 AM, Koji Sekiguchi  wrote:
      > I'm checking MultiCore/CoreAdmin stuff in branch-1.3 and noticed
      > that /admin/cores?action=STATUS returns weird path info on Windows:
      >
      > <str name="instanceDir">multicore\core0/</str>
      > <str name="dataDir">multicore\core0/data/</str>
      >
      > Backslash and slash characters are mixed in path info. Java client
      > can easily handle these weird path string, but other clients may not.
      > I think we should use file.separator system property
      > before releasing 1.3. Thought?
      
      I think clients should be able to handle mixed path separators - they
      need to be able to handle both anyway, and seeing mixed forward and
      backward slashes in windows isn't that uncommon.  We should fix it to
      be consistent (I like standardized forward slashes myself), but it
      
      1. SOLR-771.patch
        1 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 697377.

        Renamed the private method to normalizePath instead of normalizeSeparators in the patch.

        Thanks Koji and Hoss!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 697377. Renamed the private method to normalizePath instead of normalizeSeparators in the patch. Thanks Koji and Hoss!
        Hide
        Shalin Shekhar Mangar added a comment -

        Attaching patch to convert all occurrences of '/' or '\' to File.separatorChar.

        Show
        Shalin Shekhar Mangar added a comment - Attaching patch to convert all occurrences of '/' or '\' to File.separatorChar.

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development