Solr
  1. Solr
  2. SOLR-7714

reduce SearchHandler's overall use of ShardHandler objects (from N+1+x to just 1)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None

      Description

      github pull request with proposed change to follow.

        Issue Links

          Activity

          Hide
          ASF GitHub Bot added a comment -

          GitHub user cpoerschke opened a pull request:

          https://github.com/apache/lucene-solr/pull/158

          SOLR-7714: reduce SearchHandler's overall use of ShardHandler objects (from N+1+x to just 1)

          for https://issues.apache.org/jira/i#browse/SOLR-7714

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bloomberg/lucene-solr trunk-reduce-SearchHandler-object-use

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/158.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #158


          commit 0e518f15b546abd06542ae96ecd619cd5efc33dd
          Author: Christine Poerschke <cpoerschke@bloomberg.net>
          Date: 2014-11-11T13:29:43Z

          SOLR-????: tweak SearchHandler getDefaultComponents initial capacity (from 6 to 8)

          commit 093859e77ee03ae2fee23ef4fc6941a119d5d135
          Author: Christine Poerschke <cpoerschke@bloomberg.net>
          Date: 2014-09-02T11:15:35Z

          SOLR-????: reduce SearchHandler's overall use of ShardHandler objects (from N+1+x to just 1)

          before:

          • A search request to an N-shard system constructs at least N+1 ShardHandler objects in total, 1 object in the receiving solr instance and 1 object in each of the N shards that receive sub-requests.

          after:

          • A search request to an N-shard systems constructs 1 ShardHandler object in the receiving solr instance only.

          summary of change:

          • move non-distrib related code fragments from HttpShardHandler.checkDistrib to SearchHandler
          • rename ShardHandler.checkDistrib to ShardHandler.prepDistrib (to be called for distributed requests only)
          • SearchHandler constructs ShardHandler object only for distributed requests

          Show
          ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/158 SOLR-7714 : reduce SearchHandler's overall use of ShardHandler objects (from N+1+x to just 1) for https://issues.apache.org/jira/i#browse/SOLR-7714 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-reduce-SearchHandler-object-use Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 0e518f15b546abd06542ae96ecd619cd5efc33dd Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-11-11T13:29:43Z SOLR-????: tweak SearchHandler getDefaultComponents initial capacity (from 6 to 8) commit 093859e77ee03ae2fee23ef4fc6941a119d5d135 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-09-02T11:15:35Z SOLR-????: reduce SearchHandler's overall use of ShardHandler objects (from N+1+x to just 1) before: A search request to an N-shard system constructs at least N+1 ShardHandler objects in total, 1 object in the receiving solr instance and 1 object in each of the N shards that receive sub-requests. after: A search request to an N-shard systems constructs 1 ShardHandler object in the receiving solr instance only. summary of change: move non-distrib related code fragments from HttpShardHandler.checkDistrib to SearchHandler rename ShardHandler.checkDistrib to ShardHandler.prepDistrib (to be called for distributed requests only) SearchHandler constructs ShardHandler object only for distributed requests
          Hide
          ASF subversion and git services added a comment -

          Commit 1687143 from Ramkumar Aiyengar in branch 'dev/trunk'
          [ https://svn.apache.org/r1687143 ]

          SOLR-7714: Reduce SearchHandler's use of ShardHandler objects across shards in a search

          Show
          ASF subversion and git services added a comment - Commit 1687143 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1687143 ] SOLR-7714 : Reduce SearchHandler's use of ShardHandler objects across shards in a search
          Hide
          ASF subversion and git services added a comment -

          Commit 1687144 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1687144 ]

          SOLR-7714: Reduce SearchHandler's use of ShardHandler objects across shards in a search

          Show
          ASF subversion and git services added a comment - Commit 1687144 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1687144 ] SOLR-7714 : Reduce SearchHandler's use of ShardHandler objects across shards in a search
          Hide
          Ramkumar Aiyengar added a comment -

          Thanks Christine!

          Show
          Ramkumar Aiyengar added a comment - Thanks Christine!
          Hide
          Tomás Fernández Löbbe added a comment -

          I'm wondering if it's OK to commit this to 5.x. It breaks back compatibility for custom ShardHandlers.

          Show
          Tomás Fernández Löbbe added a comment - I'm wondering if it's OK to commit this to 5.x. It breaks back compatibility for custom ShardHandlers.
          Hide
          Ramkumar Aiyengar added a comment - - edited

          Reopening for discussion, let me think this through, but opinions welcome on if this is a "supported" interface – unfortunately there isn't much for me to go by except for what I hear from fellow committers.

          Show
          Ramkumar Aiyengar added a comment - - edited Reopening for discussion, let me think this through, but opinions welcome on if this is a "supported" interface – unfortunately there isn't much for me to go by except for what I hear from fellow committers.
          Hide
          Tomás Fernández Löbbe added a comment -

          I don't want to be intransigent with this, my comment is just because this seems like a non-expert extension point for users. Maybe most custom code changes regarding to this Jira are minor, but I'm wondering if we should be requiring them for users in minor version upgrades. Just want to raise the question and hear opinions.

          Show
          Tomás Fernández Löbbe added a comment - I don't want to be intransigent with this, my comment is just because this seems like a non-expert extension point for users. Maybe most custom code changes regarding to this Jira are minor, but I'm wondering if we should be requiring them for users in minor version upgrades. Just want to raise the question and hear opinions.
          Hide
          Ramkumar Aiyengar added a comment -

          If there are no other objections, I will add a note to CHANGES.txt mentioning this in the upgrade notes, hopefully that should help..

          Show
          Ramkumar Aiyengar added a comment - If there are no other objections, I will add a note to CHANGES.txt mentioning this in the upgrade notes, hopefully that should help..
          Hide
          ASF subversion and git services added a comment -

          Commit 1689105 from Ramkumar Aiyengar in branch 'dev/trunk'
          [ https://svn.apache.org/r1689105 ]

          SOLR-7714: Add note about ShardHandler interface change to upgrade notes

          Show
          ASF subversion and git services added a comment - Commit 1689105 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1689105 ] SOLR-7714 : Add note about ShardHandler interface change to upgrade notes
          Hide
          ASF subversion and git services added a comment -

          Commit 1689106 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1689106 ]

          SOLR-7714: Add note about ShardHandler interface change to upgrade notes

          Show
          ASF subversion and git services added a comment - Commit 1689106 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1689106 ] SOLR-7714 : Add note about ShardHandler interface change to upgrade notes
          Hide
          Shalin Shekhar Mangar added a comment -

          Bulk close for 5.3.0 release

          Show
          Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release
          Hide
          ASF GitHub Bot added a comment -

          Github user cpoerschke closed the pull request at:

          https://github.com/apache/lucene-solr/pull/158

          Show
          ASF GitHub Bot added a comment - Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/158

            People

            • Assignee:
              Ramkumar Aiyengar
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development