Solr
  1. Solr
  2. SOLR-7710

replace various "async" with CommonAdminParams.ASYNC

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None

      Description

      • github pull request with proposed changes to follow shortly.
      • Motivation is addition of a test case for an unrelated change (not yet uploaded) and not wishing to add literally "async" in that test case. Using CommonAdminParams.ASYNC instead of "async" can also make code base 'navigation' a little easier e.g. locating of existing test cases.
      • The proposed change also adds a little CommonAdminParamsTest to test the backwards compatibility of CommonAdminParams parameter constants i.e. if someone accidentally changes those constants then the test will flag that up.
      1. SOLR-7710.patch
        18 kB
        Ramkumar Aiyengar

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user cpoerschke opened a pull request:

        https://github.com/apache/lucene-solr/pull/156

        SOLR-7710: replace various "async" with CommonAdminParams.ASYNC

        for https://issues.apache.org/jira/i#browse/SOLR-7710

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-ocp-async

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/156.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #156


        commit 0fc933164c89c65c721857cba4c1921e86b3aeb2
        Author: Christine Poerschke <cpoerschke@bloomberg.net>
        Date: 2015-04-29T18:26:46Z

        SOLR-????: replace various "async" with CommonAdminParams.ASYNC

        This change turns
        org.apache.solr.cloud.OverseerCollectionProcessor.ASYNC
        into
        org.apache.solr.common.params.CommonAdminParams.ASYNC
        and then uses it in various places (instead of "async").

        The commit also adds a CommonAdminParamsTest to test the backwards compatibility of CommonAdminParams parameter constants. If someone accidentally changes those constants then the test will flag that up.


        Show
        ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/156 SOLR-7710 : replace various "async" with CommonAdminParams.ASYNC for https://issues.apache.org/jira/i#browse/SOLR-7710 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-ocp-async Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #156 commit 0fc933164c89c65c721857cba4c1921e86b3aeb2 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2015-04-29T18:26:46Z SOLR-????: replace various "async" with CommonAdminParams.ASYNC This change turns org.apache.solr.cloud.OverseerCollectionProcessor.ASYNC into org.apache.solr.common.params.CommonAdminParams.ASYNC and then uses it in various places (instead of "async"). The commit also adds a CommonAdminParamsTest to test the backwards compatibility of CommonAdminParams parameter constants. If someone accidentally changes those constants then the test will flag that up.
        Hide
        Ramkumar Aiyengar added a comment -

        Slightly modified patch to use static imports where they are already used elsewhere in the file..

        Show
        Ramkumar Aiyengar added a comment - Slightly modified patch to use static imports where they are already used elsewhere in the file..
        Hide
        ASF subversion and git services added a comment -

        Commit 1688039 from Ramkumar Aiyengar in branch 'dev/trunk'
        [ https://svn.apache.org/r1688039 ]

        SOLR-7710: Replace async occurrences with CommonAdminParams.ASYNC

        Show
        ASF subversion and git services added a comment - Commit 1688039 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1688039 ] SOLR-7710 : Replace async occurrences with CommonAdminParams.ASYNC
        Hide
        ASF subversion and git services added a comment -

        Commit 1688040 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1688040 ]

        SOLR-7710: Replace async occurrences with CommonAdminParams.ASYNC

        Show
        ASF subversion and git services added a comment - Commit 1688040 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1688040 ] SOLR-7710 : Replace async occurrences with CommonAdminParams.ASYNC
        Hide
        Ramkumar Aiyengar added a comment -

        Thanks Christine!

        Show
        Ramkumar Aiyengar added a comment - Thanks Christine!
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release
        Hide
        ASF GitHub Bot added a comment -

        Github user cpoerschke closed the pull request at:

        https://github.com/apache/lucene-solr/pull/156

        Show
        ASF GitHub Bot added a comment - Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/156

          People

          • Assignee:
            Ramkumar Aiyengar
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development