Solr
  1. Solr
  2. SOLR-7660

Avoid redundant 'exists' calls made to ZK while fetching cluster state updates

    Details

      Description

      As noted in https://issues.apache.org/jira/browse/SOLR-7636?focusedCommentId=14578332&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14578332

      we have CollectionsHandler -> ZK getChildren (/live_nodes) + ZK read (/clusterstate.json) + ZK getChildren + N * ZK exists (for getIndividualColls) + W * ZK exists + W * getData (for watched collections) + (N-W) * ZK exists + (N-W) * ZK getData (for non-watched collections).

      Some of the ZK exists calls can be avoided without changing the outcome.

      1. SOLR-7660.patch
        6 kB
        Shalin Shekhar Mangar
      2. SOLR-7660.patch
        4 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -
        1. Removed zk exists call in getCollectionLive because it already catches NoNodeException and returns null
        2. Added a comment in getIndividualColls as to why the zk exists call is necessary in that method
        Show
        Shalin Shekhar Mangar added a comment - Removed zk exists call in getCollectionLive because it already catches NoNodeException and returns null Added a comment in getIndividualColls as to why the zk exists call is necessary in that method
        Hide
        Shalin Shekhar Mangar added a comment -

        I renamed getIndividualColls to getStateFormat2CollectionNames. I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - I renamed getIndividualColls to getStateFormat2CollectionNames. I'll commit this shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1684815 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1684815 ]

        SOLR-7660: Avoid redundant 'exists' calls made to ZK while fetching cluster state updates

        Show
        ASF subversion and git services added a comment - Commit 1684815 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1684815 ] SOLR-7660 : Avoid redundant 'exists' calls made to ZK while fetching cluster state updates
        Hide
        ASF subversion and git services added a comment -

        Commit 1684816 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1684816 ]

        SOLR-7660: Avoid redundant 'exists' calls made to ZK while fetching cluster state updates

        Show
        ASF subversion and git services added a comment - Commit 1684816 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1684816 ] SOLR-7660 : Avoid redundant 'exists' calls made to ZK while fetching cluster state updates
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development