[SOLR-7659] DirectoryFileStream.releaseCommitPointAndExtendReserve -- should it extend first?

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.2.1
• Fix Version/s: 5.3, 6.0
• Component/s: replication (java)
• Assignee: Shawn Heisey
• Reporter: Shawn Heisey
• Created: 10/Jun/15 15:30
• Updated: 09/May/16 18:58
• Resolved: 11/Jun/15 05:21

Description

After a misunderstanding on my part, leading to an incorrect documentation edit, [~shalinmangar] helped me understand how the commit reserve duration works.

The resulting discussion on the dev list brought up a possible problem in ReplicationHandler. We wondered whether it might be possible for another thread to sneak in a commit point deletion in between the two statements found in the releaseCommitPointAndExtendReserve method on the DirectoryFileStream object. If it is safe to do so, I propose reversing those two statements so the reserve extension is done before releasing the commit point.