Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7659

DirectoryFileStream.releaseCommitPointAndExtendReserve -- should it extend first?

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.2.1
    • Fix Version/s: 5.3, 6.0
    • Component/s: replication (java)
    • Labels:
      None

      Description

      After a misunderstanding on my part, leading to an incorrect documentation edit, Shalin Shekhar Mangar helped me understand how the commit reserve duration works.

      The resulting discussion on the dev list brought up a possible problem in ReplicationHandler. We wondered whether it might be possible for another thread to sneak in a commit point deletion in between the two statements found in the releaseCommitPointAndExtendReserve method on the DirectoryFileStream object. If it is safe to do so, I propose reversing those two statements so the reserve extension is done before releasing the commit point.

        Attachments

        1. SOLR-7659.patch
          2 kB
          Shawn Heisey
        2. SOLR-7659.patch
          3 kB
          Shawn Heisey

          Activity

            People

            • Assignee:
              elyograg Shawn Heisey
              Reporter:
              elyograg Shawn Heisey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: