Solr
  1. Solr
  2. SOLR-7645

Remove explicitly defined plugins that are now implicitly available

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Most (probably not all) defined built-in handlers can be removed from the many example and test solrconfig.xml's in Solr's source tree. See ImplicitPlugins.java for details. Handlers such as /admin/ping, /admin/luke, /admin/system, ... and so on are now implicitly defined. Removing these from the configs that users clone will (c)lean it up a lot.

      1. SOLR-7645.patch
        106 kB
        Erik Hatcher

        Activity

        Hide
        Erik Hatcher added a comment -

        lotsa minuses! removed most (not all, there were some non-default definitions in use) of the plugins from solrconfig's that are implicitly defined in ImplicitPlugins.java. Needs thorough testing - locally all seems fine currently. I'm running more tests as I upload this patch.

        Show
        Erik Hatcher added a comment - lotsa minuses! removed most (not all, there were some non-default definitions in use) of the plugins from solrconfig's that are implicitly defined in ImplicitPlugins.java. Needs thorough testing - locally all seems fine currently. I'm running more tests as I upload this patch.
        Hide
        Erik Hatcher added a comment -

        Of note, there were several references to the never official and long removed "EditFileRequestHandler" that are also removed in this patch.

        Show
        Erik Hatcher added a comment - Of note, there were several references to the never official and long removed "EditFileRequestHandler" that are also removed in this patch.
        Hide
        Erik Hatcher added a comment -

        And "ant test" passes with this patch.

        I plan to commit this soon so as to not sit on this patch for long. Anyone see any issues?

        Show
        Erik Hatcher added a comment - And "ant test" passes with this patch. I plan to commit this soon so as to not sit on this patch for long. Anyone see any issues?
        Hide
        Erik Hatcher added a comment - - edited

        Committed to trunk r1684080 (oops, sorry, missed putting JIRA in commit message). If Jenkins is happy with this, I'll merge to 5x and commit tomorrow. There are some files (CDCR) that aren't on 5x that were modified in this commit, just FYI.

        Show
        Erik Hatcher added a comment - - edited Committed to trunk r1684080 (oops, sorry, missed putting JIRA in commit message). If Jenkins is happy with this, I'll merge to 5x and commit tomorrow. There are some files (CDCR) that aren't on 5x that were modified in this commit, just FYI.
        Hide
        Noble Paul added a comment -

        +1

        Show
        Noble Paul added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1684182 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1684182 ]

        SOLR-7645: Remove explicitly defined request handlers from example and test solrconfig's that are already defined implicitly (merged from trunk r1684080)

        Show
        ASF subversion and git services added a comment - Commit 1684182 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1684182 ] SOLR-7645 : Remove explicitly defined request handlers from example and test solrconfig's that are already defined implicitly (merged from trunk r1684080)
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development