Solr
  1. Solr
  2. SOLR-763

Add support for Lucene's PositionFilter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      Patch so that ShingleFilterFactory can deserialise the coterminalPositionIncrement property.

      [Edit] – FilterFactory for Lucene's PositionFilter

      1. SOLR-763.patch
        2 kB
        Shalin Shekhar Mangar
      2. SOLR-763.patch
        1 kB
        mck
      3. SOLR-763-PositionFilterFactory.patch
        2 kB
        mck
      4. SOLR-763-PositionFilterFactory.patch
        2 kB
        mck

        Issue Links

          Activity

          mck created issue -
          mck made changes -
          Field Original Value New Value
          Link This issue incorporates LUCENE-1380 [ LUCENE-1380 ]
          Hide
          mck added a comment -

          Patch to support new property coterminalPositionIncrement that appears in LUCENE-1380

          Show
          mck added a comment - Patch to support new property coterminalPositionIncrement that appears in LUCENE-1380
          mck made changes -
          Attachment SOLR-763.patch [ 12389826 ]
          mck made changes -
          Attachment SOLR-763.patch [ 12389826 ]
          Hide
          mck added a comment -

          New patch with option now named enablePositions

          Show
          mck added a comment - New patch with option now named enablePositions
          mck made changes -
          Attachment SOLR-763.patch [ 12389926 ]
          mck made changes -
          Summary Support for LUCENE-1380 :: ShingleFilter.coterminalPositionIncrement Support for LUCENE-1380 :: ShingleFilter.enablePositions
          mck made changes -
          Attachment SOLR-763.patch [ 12389926 ]
          Hide
          mck added a comment -

          Patch updated accordingly to match latest patch in LUCENE-1380

          Show
          mck added a comment - Patch updated accordingly to match latest patch in LUCENE-1380
          mck made changes -
          Attachment SOLR-763.patch [ 12390262 ]
          Hide
          mck added a comment -

          Alternative patch for matching PositionFilter.java patch found in LUCENE-1380

          Show
          mck added a comment - Alternative patch for matching PositionFilter.java patch found in LUCENE-1380
          mck made changes -
          Attachment SOLR-763-PositionFilterFactory.patch [ 12390754 ]
          mck made changes -
          Attachment SOLR-763-PositionFilterFactory.patch [ 12390909 ]
          Hide
          Shalin Shekhar Mangar added a comment -

          We can commit this when the Lucene jars in lib are upgraded.

          Show
          Shalin Shekhar Mangar added a comment - We can commit this when the Lucene jars in lib are upgraded.
          Shalin Shekhar Mangar made changes -
          Component/s Analysis [ 12312520 ]
          Assignee Shalin Shekhar Mangar [ shalinmangar ]
          Hide
          Shalin Shekhar Mangar added a comment -

          Added basic javadocs. I'll commit shortly.

          Mck, can you please update the wiki with information about this filter?

          http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters

          Show
          Shalin Shekhar Mangar added a comment - Added basic javadocs. I'll commit shortly. Mck, can you please update the wiki with information about this filter? http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters
          Shalin Shekhar Mangar made changes -
          Attachment SOLR-763.patch [ 12399113 ]
          Shalin Shekhar Mangar made changes -
          Summary Support for LUCENE-1380 :: ShingleFilter.enablePositions Add support for Lucene's PositionFilter
          Description Patch so that ShingleFilterFactory can deserialise the coterminalPositionIncrement property. Patch so that ShingleFilterFactory can deserialise the coterminalPositionIncrement property.

          [Edit] -- FilterFactory for Lucene's PositionFilter
          Hide
          Shalin Shekhar Mangar added a comment -

          Committed revision 739247.

          Thanks Mck!

          Show
          Shalin Shekhar Mangar added a comment - Committed revision 739247. Thanks Mck!
          Shalin Shekhar Mangar made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Hide
          mck added a comment -

          done. would you mind checking it Shalin, especially as it is my first edit to wiki.apache.org

          Show
          mck added a comment - done. would you mind checking it Shalin, especially as it is my first edit to wiki.apache.org
          Hide
          Shalin Shekhar Mangar added a comment -

          Looks great! Thank you!

          Show
          Shalin Shekhar Mangar added a comment - Looks great! Thank you!
          Hide
          Grant Ingersoll added a comment -

          Bulk close for Solr 1.4

          Show
          Grant Ingersoll added a comment - Bulk close for Solr 1.4
          Grant Ingersoll made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              mck
            • Votes:
              10 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development