Solr
  1. Solr
  2. SOLR-7624

Correct wrong spelling of zkCredentialsProvider

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: security, SolrCloud
    • Labels:
      None

      Description

      SolrXmlConfig.java contain the string "zkCredientialsProvider". It should be corrected to "zkCredentialsProvider". I believe no other changes are necessary - there are no tests covering this AFAIK

      1. SOLR-7624.patch
        9 kB
        Ramkumar Aiyengar
      2. SOLR-7624.patch
        2 kB
        Xu Zhang

        Activity

        Hide
        Xu Zhang added a comment -

        Simple fix and a test case.

        Show
        Xu Zhang added a comment - Simple fix and a test case.
        Hide
        Ramkumar Aiyengar added a comment -

        I can pick this up, but changing this is a backward compat break, which seems minor (with a mention in CHANGES), but I would like a second opinion..

        Show
        Ramkumar Aiyengar added a comment - I can pick this up, but changing this is a backward compat break, which seems minor (with a mention in CHANGES), but I would like a second opinion..
        Hide
        Mark Miller added a comment -

        We should probably recognize both for 5x and one for 6x.

        Show
        Mark Miller added a comment - We should probably recognize both for 5x and one for 6x.
        Hide
        Ramkumar Aiyengar added a comment -

        That was going to be my alternative if back compat is a big deal. Will go with that then..

        Show
        Ramkumar Aiyengar added a comment - That was going to be my alternative if back compat is a big deal. Will go with that then..
        Hide
        Ramkumar Aiyengar added a comment -

        Updated patch to add the correct spelling as an alternative.

        Show
        Ramkumar Aiyengar added a comment - Updated patch to add the correct spelling as an alternative.
        Hide
        ASF subversion and git services added a comment -

        Commit 1685318 from Ramkumar Aiyengar in branch 'dev/trunk'
        [ https://svn.apache.org/r1685318 ]

        SOLR-7624: Correct wrong spelling of zkCredentialsProvider in solrcloud section of solr.xml.
        The older misspelling is still present (for purposes of branch_5x, to be removed in the next commit).

        Show
        ASF subversion and git services added a comment - Commit 1685318 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1685318 ] SOLR-7624 : Correct wrong spelling of zkCredentialsProvider in solrcloud section of solr.xml. The older misspelling is still present (for purposes of branch_5x, to be removed in the next commit).
        Hide
        ASF subversion and git services added a comment -

        Commit 1685319 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1685319 ]

        SOLR-7624: Correct wrong spelling of zkCredentialsProvider in solrcloud section of solr.xml

        Show
        ASF subversion and git services added a comment - Commit 1685319 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1685319 ] SOLR-7624 : Correct wrong spelling of zkCredentialsProvider in solrcloud section of solr.xml
        Hide
        ASF subversion and git services added a comment -

        Commit 1685323 from Ramkumar Aiyengar in branch 'dev/trunk'
        [ https://svn.apache.org/r1685323 ]

        SOLR-7624: Remove deprecated zkCredientialsProvider element in solrcloud section of solr.xml

        Show
        ASF subversion and git services added a comment - Commit 1685323 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1685323 ] SOLR-7624 : Remove deprecated zkCredientialsProvider element in solrcloud section of solr.xml
        Hide
        Ramkumar Aiyengar added a comment -

        Thanks everyone!

        Show
        Ramkumar Aiyengar added a comment - Thanks everyone!
        Hide
        Mark Miller added a comment -

        That was going to be my alternative if back compat is a big deal.

        I think it is - sucks to do a point upgrade an have things break. Especially if maintaining back compat is relatively simple. I'd like to start hashing out more official back compat policies for Solr like Lucene has. We will never be able to nicely support rolling upgrades without it.

        Show
        Mark Miller added a comment - That was going to be my alternative if back compat is a big deal. I think it is - sucks to do a point upgrade an have things break. Especially if maintaining back compat is relatively simple. I'd like to start hashing out more official back compat policies for Solr like Lucene has. We will never be able to nicely support rolling upgrades without it.
        Hide
        Ramkumar Aiyengar added a comment -

        I'd like to start hashing out more official back compat policies for Solr like Lucene has. We will never be able to nicely support rolling upgrades without it.

        +1

        Show
        Ramkumar Aiyengar added a comment - I'd like to start hashing out more official back compat policies for Solr like Lucene has. We will never be able to nicely support rolling upgrades without it. +1
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Ramkumar Aiyengar
            Reporter:
            Per Steffensen
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development