Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7614

Distributed Pivot Facet not thread safe

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2
    • Component/s: None
    • Labels:
      None

      Description

      I just happened to notice the following added to FacetComponent:

        /**
         * Incremented counter used to track the values being refined in a given request.
         * This counter is used in conjunction with {@link PivotFacet#REFINE_PARAM} to identify
         * which refinement values are associated with which pivots.
         */
        int pivotRefinementCounter = 0;
      

      That counter is incremented for each refinement request for correlation, and then reset to 0 at the end. This will obviously break for concurrent distributed pivot facet requests.

      pivotRefinementCounter should be moved to per-request storage.

        Attachments

          Activity

            People

            • Assignee:
              yseeley@gmail.com Yonik Seeley
              Reporter:
              yseeley@gmail.com Yonik Seeley
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: