[SOLR-7614] Distributed Pivot Facet not thread safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.2
• Assignee: Yonik Seeley
• Reporter: Yonik Seeley
• Created: 31/May/15 14:10
• Updated: 15/Jun/15 21:42
• Resolved: 03/Jun/15 00:34

Description

I just happened to notice the following added to FacetComponent:

  /**
   * Incremented counter used to track the values being refined in a given request.
   * This counter is used in conjunction with {@link PivotFacet#REFINE_PARAM} to identify
   * which refinement values are associated with which pivots.
   */
  int pivotRefinementCounter = 0;

That counter is incremented for each refinement request for correlation, and then reset to 0 at the end. This will obviously break for concurrent distributed pivot facet requests.

pivotRefinementCounter should be moved to per-request storage.