Solr
  1. Solr
  2. SOLR-7595

Allow method chaining for all CollectionAdminRequest

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: clients - java, SolrJ
    • Labels:
      None

      Description

      Allow methods to be chained for all CollectionAdminRequests so that code like the following can be written:

      Create createCollectionRequest = new Create()
                    .setCollectionName("testasynccollectioncreation")
                    .setNumShards(1)
                    .setConfigName("conf1")
                    .setAsyncId("1001");
      
      1. SOLR-7595.patch
        83 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        This was slightly more complex because of the hierarchy. In order to make this work, I had to make the base class CollectionAdminRequest as abstract. Though this is a back-compat break but this class is marked as experimental.

        I also changed many tests to make use of chaining but I didn't change in all places.

        Show
        Shalin Shekhar Mangar added a comment - This was slightly more complex because of the hierarchy. In order to make this work, I had to make the base class CollectionAdminRequest as abstract. Though this is a back-compat break but this class is marked as experimental. I also changed many tests to make use of chaining but I didn't change in all places.
        Hide
        ASF subversion and git services added a comment -

        Commit 1681808 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1681808 ]

        SOLR-7595: Allow method chaining for all CollectionAdminRequests in Solrj

        Show
        ASF subversion and git services added a comment - Commit 1681808 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1681808 ] SOLR-7595 : Allow method chaining for all CollectionAdminRequests in Solrj
        Hide
        ASF subversion and git services added a comment -

        Commit 1681811 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1681811 ]

        SOLR-7595: Allow method chaining for all CollectionAdminRequests in Solrj

        Show
        ASF subversion and git services added a comment - Commit 1681811 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1681811 ] SOLR-7595 : Allow method chaining for all CollectionAdminRequests in Solrj
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development