I tried to debug some jenkins logs today and realized a bunch of this logging is incomplete and buggy.

The Overseer uses MDC logging all wrong IMO. The logging should identify the active core, not the core being operated on by overseer actions.

Getting closer to something reasonable.

I've also unified our context logging solution - we can't maintain one approach for tests and another for production.

Okay, now it's fairly solid.

I've tweaked the heck out of this to make the logging as nice and complete and universal as I could.

The logging should identify the active core, not the core being operated on by overseer actions.

I think if the Overseer needs better logging around what it's doing, that should be logged specifically. Lot's not overload how we use this context.

Commit 1682020 from Mark Miller in branch 'dev/trunk'
[ https://svn.apache.org/r1682020 ]

SOLR-7590: Finish and improve MDC context logging support.

Commit 1682031 from Mark Miller in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1682031 ]

SOLR-7590: Finish and improve MDC context logging support.

Looks like 5x is failing because the Supplier code is Java 8. Still trying to figure out how this appears to work on my dev machine even when running with a java 7 jvm...

Commit 1682057 from Mark Miller in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1682057 ]

SOLR-7590: Java8 code -> Java7 for branch_5x.

Might be some tweaking we still want to do, but we can open up further issues.

Hi Mark,

I am wondering why you be so verbose in Java 8's code. The main reason for ThreadLocal.withInitial() is to use it like that:

private static final ThreadLocal<Integer> CALL_DEPTH = ThreadLocal.withInitial(() -> 0);

Using a Supplier without a lambda is not the intention behind this method /API
In Java 7, you can use the code like this fix comitted. If you want it verbose in Java 8, I would also use the Java 7 code...

Uwe

I filed SOLR-7699 so I won't lose this.

Bulk close for 5.3.0 release