Solr
  1. Solr
  2. SOLR-758

Enhance DisMaxQParserPlugin to support full-Solr syntax and to support alternate escaping strategies.

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.3
    • Fix Version/s: 4.9, 5.0
    • Component/s: search
    • Labels:
      None

      Description

      The DisMaxQParserPlugin has a variety of nice features; chief among them is that is uses the DisjunctionMaxQueryParser. However it imposes limitations on the syntax.

      I've enhanced the DisMax QParser plugin to use a pluggable query string re-writer (via subclass extension) instead of hard-coding the logic currently embedded within it (i.e. the escape nearly everything logic). Additionally, I've made this QParser have a notion of a "simple" syntax (the default) or non-simple in which case some of the logic in this QParser doesn't occur because it's irrelevant (phrase boosting and min-should-max in particular). As part of my work I significantly moved the code around to make it clearer and more extensible. I also chose to rename it to suggest it's role as a parser for user queries.

      Attachment to follow...

      1. UserQParser.java-umlauts.patch
        0.9 kB
        Simon Lachinger
      2. AdvancedQParserPlugin.java
        0.8 kB
        David Smiley
      3. DisMaxQParserPlugin.java
        2 kB
        David Smiley
      4. UserQParser.java
        11 kB
        David Smiley
      5. AdvancedQParserPlugin.java
        0.8 kB
        David Smiley
      6. DisMaxQParserPlugin.java
        2 kB
        David Smiley
      7. UserQParser.java
        11 kB
        David Smiley

        Issue Links

          Activity

          David Smiley created issue -
          David Smiley made changes -
          Field Original Value New Value
          Attachment UserQParser.java [ 12389587 ]
          Attachment AdvancedQParserPlugin.java [ 12389589 ]
          Attachment DisMaxQParserPlugin.java [ 12389588 ]
          Shalin Shekhar Mangar made changes -
          Fix Version/s 1.5 [ 12313566 ]
          David Smiley made changes -
          Attachment UserQParser.java [ 12418157 ]
          Attachment DisMaxQParserPlugin.java [ 12418158 ]
          Attachment AdvancedQParserPlugin.java [ 12418159 ]
          David Smiley made changes -
          Link This issue depends upon SOLR-756 [ SOLR-756 ]
          David Smiley made changes -
          Link This issue depends upon SOLR-757 [ SOLR-757 ]
          David Smiley made changes -
          Link This issue relates to SOLR-629 [ SOLR-629 ]
          Simon Lachinger made changes -
          Attachment UserQParser.java-umlauts.patch [ 12420016 ]
          Yonik Seeley made changes -
          Link This issue is blocked by SOLR-1553 [ SOLR-1553 ]
          Hoss Man made changes -
          Fix Version/s Next [ 12315093 ]
          Fix Version/s 1.5 [ 12313566 ]
          Hoss Man made changes -
          Fix Version/s 3.2 [ 12316172 ]
          Fix Version/s Next [ 12315093 ]
          Robert Muir made changes -
          Fix Version/s 3.3 [ 12316471 ]
          Fix Version/s 3.2 [ 12316172 ]
          Robert Muir made changes -
          Fix Version/s 3.4 [ 12316683 ]
          Fix Version/s 4.0 [ 12314992 ]
          Fix Version/s 3.3 [ 12316471 ]
          Robert Muir made changes -
          Fix Version/s 3.5 [ 12317876 ]
          Fix Version/s 3.4 [ 12316683 ]
          Simon Willnauer made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Fix Version/s 3.5 [ 12317876 ]
          Hoss Man made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Robert Muir made changes -
          Fix Version/s 4.1 [ 12321141 ]
          Fix Version/s 4.0 [ 12314992 ]
          Mark Miller made changes -
          Fix Version/s 4.2 [ 12323893 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.1 [ 12321141 ]
          Robert Muir made changes -
          Fix Version/s 4.3 [ 12324128 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.2 [ 12323893 ]
          Uwe Schindler made changes -
          Fix Version/s 4.4 [ 12324324 ]
          Fix Version/s 4.3 [ 12324128 ]
          Steve Rowe made changes -
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.5 [ 12324743 ]
          Fix Version/s 4.4 [ 12324324 ]
          Adrien Grand made changes -
          Fix Version/s 4.6 [ 12325000 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.5 [ 12324743 ]
          Uwe Schindler made changes -
          Fix Version/s 4.7 [ 12325573 ]
          Fix Version/s 4.6 [ 12325000 ]
          David Smiley made changes -
          Fix Version/s 4.8 [ 12326254 ]
          Fix Version/s 4.7 [ 12325573 ]
          Uwe Schindler made changes -
          Fix Version/s 4.9 [ 12326731 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.8 [ 12326254 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              David Smiley
            • Votes:
              7 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:

                Development