Solr
  1. Solr
  2. SOLR-7532

Nuke all traces of commitIntervalLowerBound from configs

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      I noticed this first via the Config API which shows a config element called "commitIntervalLowerBound" under the updateHandler section. A quick search of this property shows it that it is not used anywhere. In fact, some of the old solrconfig.xml used by tests and the extraction contrib had the following to say about this property:

      <!-- represents a lower bound on the frequency that commits may
          occur (in seconds). NOTE: not yet implemented
          
          <commitIntervalLowerBound>0</commitIntervalLowerBound>
          -->
      

      This is clearly not used so let's remove it.

        Activity

        Hide
        Marius Grama added a comment -

        This is a patch implementing the removal of the support in the solrconfig.xml file for the parameter commitIntervalLowerBound.

        I've checked in the commit annotations where was the commitIntervalLowerBound parameter handling introduced and it dates back before 2010 (this can be seen in the annotations of the file lucene-solr/solr/core/src/test-files/solr/collection1/conf - when the Solr code was moved to a new trunk).

        Show
        Marius Grama added a comment - This is a patch implementing the removal of the support in the solrconfig.xml file for the parameter commitIntervalLowerBound . I've checked in the commit annotations where was the commitIntervalLowerBound parameter handling introduced and it dates back before 2010 (this can be seen in the annotations of the file lucene-solr/solr/core/src/test-files/solr/collection1/conf - when the Solr code was moved to a new trunk).
        Hide
        ASF subversion and git services added a comment -

        Commit 1679522 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1679522 ]

        SOLR-7532: Removed occurrences of the unused 'commitIntervalLowerBound' property for updateHandler elements from Solr configuration

        Show
        ASF subversion and git services added a comment - Commit 1679522 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1679522 ] SOLR-7532 : Removed occurrences of the unused 'commitIntervalLowerBound' property for updateHandler elements from Solr configuration
        Hide
        ASF subversion and git services added a comment -

        Commit 1679525 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1679525 ]

        SOLR-7532: Removed occurrences of the unused 'commitIntervalLowerBound' property for updateHandler elements from Solr configuration

        Show
        ASF subversion and git services added a comment - Commit 1679525 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1679525 ] SOLR-7532 : Removed occurrences of the unused 'commitIntervalLowerBound' property for updateHandler elements from Solr configuration
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Marius!

        I found and removed one more instance of this property in the file: lucene/dev/trunk/solr/core/src/test-files/solr/collection1/conf/solrconfig-plugcollector.xml

        Show
        Shalin Shekhar Mangar added a comment - Thanks Marius! I found and removed one more instance of this property in the file: lucene/dev/trunk/solr/core/src/test-files/solr/collection1/conf/solrconfig-plugcollector.xml
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development