Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7529

NullPointerException in RELOAD-command in CoreAdmin

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      http://solr.local:8983/solr/admin/cores?action=RELOAD

      
      <?xml version="1.0" encoding="UTF-8"?>
      <response>
      <lst name="responseHeader"><int name="status">500</int><int name="QTime">1</int></lst><lst name="error"><str name="trace">java.lang.NullPointerException
      	at java.util.TreeMap.getEntry(TreeMap.java:347)
      	at java.util.TreeMap.containsKey(TreeMap.java:232)
      	at java.util.TreeSet.contains(TreeSet.java:234)
      	at org.apache.solr.handler.admin.CoreAdminHandler.handleReloadAction(CoreAdminHandler.java:713)
      	at org.apache.solr.handler.admin.CoreAdminHandler.handleRequestInternal(CoreAdminHandler.java:223)
      	at org.apache.solr.handler.admin.CoreAdminHandler.handleRequestBody(CoreAdminHandler.java:186)
      	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:144)
      	at org.apache.solr.servlet.SolrDispatchFilter.handleAdminRequest(SolrDispatchFilter.java:736)
      	at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:261)
      	at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:204)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
      	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
      	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
      	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
      	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1075)
      	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:384)
      	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
      	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1009)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
      	at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
      	at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
      	at org.eclipse.jetty.server.Server.handle(Server.java:368)
      	at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
      	at org.eclipse.jetty.server.BlockingHttpConnection.handleRequest(BlockingHttpConnection.java:53)
      	at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:942)
      	at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1004)
      	at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:640)
      	at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
      	at org.eclipse.jetty.server.BlockingHttpConnection.handle(BlockingHttpConnection.java:72)
      	at org.eclipse.jetty.server.bio.SocketConnector$ConnectorEndPoint.run(SocketConnector.java:264)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
      	at java.lang.Thread.run(Thread.java:745)
      </str><int name="code">500</int></lst>
      </response>
      

      http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java?view=markup#l768

      1. SOLR-7529.patch
        2 kB
        Edward Ribeiro

        Activity

        Hide
        elyograg Shawn Heisey added a comment -

        This is a lack of input validation - there should be a null check on at least the "core" parameter, and the resulting error needs to explain the problem. The RELOAD action is not the only one that is missing validation.

        Show
        elyograg Shawn Heisey added a comment - This is a lack of input validation - there should be a null check on at least the "core" parameter, and the resulting error needs to explain the problem. The RELOAD action is not the only one that is missing validation.
        Hide
        eribeiro Edward Ribeiro added a comment -

        Hi Shawn Heisey, I have attached a patch for this issue and a related one: SOLR-7705. Let me know if they need some tweaking or fix.

        Cheers.

        Show
        eribeiro Edward Ribeiro added a comment - Hi Shawn Heisey , I have attached a patch for this issue and a related one: SOLR-7705 . Let me know if they need some tweaking or fix. Cheers.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1690426 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1690426 ]

        SOLR-7529: CoreAdminHandler Reload throws NPE on null core name instead of a bad request error

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1690426 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1690426 ] SOLR-7529 : CoreAdminHandler Reload throws NPE on null core name instead of a bad request error
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1690427 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1690427 ]

        SOLR-7529: CoreAdminHandler Reload throws NPE on null core name instead of a bad request error

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1690427 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1690427 ] SOLR-7529 : CoreAdminHandler Reload throws NPE on null core name instead of a bad request error
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Jellyfrog and Edward!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Jellyfrog and Edward!
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            Jellyfrog Jellyfrog
          • Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development