Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7528

Simplify Interfaces used in Streaming Expressions

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.2, 6.0
    • Fix Version/s: 6.0
    • Component/s: SolrJ
    • Labels:

      Description

      FieldComparator and StreamComparator have been collapsed into a single class StreamComparator. There was no need for a separate abstract class.

      Added null checks in StreamComparator. For now if both are null then they will evaluate to equal. We can add a later enhancement under a new ticket to make that configurable.

      Interfaces ExpressibleStream and ExpressibleComparator have been collapsed into interface Expressible. They defined the same interface and there's no reason to have separate interfaces for them.

      1. SOLR-7528.patch
        57 kB
        Dennis Gove

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1686481 from Joel Bernstein in branch 'dev/trunk'
          [ https://svn.apache.org/r1686481 ]

          SOLR-7513, SOLR-7528: Add Equalitors to Streaming Expressions

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1686481 from Joel Bernstein in branch 'dev/trunk' [ https://svn.apache.org/r1686481 ] SOLR-7513 , SOLR-7528 : Add Equalitors to Streaming Expressions
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1692325 from Joel Bernstein in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1692325 ]

          SOLR-7513, SOLR-7528: Add Equalitors to Streaming Expressions

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1692325 from Joel Bernstein in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1692325 ] SOLR-7513 , SOLR-7528 : Add Equalitors to Streaming Expressions
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1692330 from Joel Bernstein in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1692330 ]

          SOLR-7513, SOLR-7528: Revert 5x commit

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1692330 from Joel Bernstein in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1692330 ] SOLR-7513 , SOLR-7528 : Revert 5x commit
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1694907 from Joel Bernstein in branch 'dev/trunk'
          [ https://svn.apache.org/r1694907 ]

          SOLR-7528: Updated CHANGES.txt

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1694907 from Joel Bernstein in branch 'dev/trunk' [ https://svn.apache.org/r1694907 ] SOLR-7528 : Updated CHANGES.txt
          Hide
          joel.bernstein Joel Bernstein added a comment -

          Release with Solr 6

          Show
          joel.bernstein Joel Bernstein added a comment - Release with Solr 6

            People

            • Assignee:
              Unassigned
              Reporter:
              dpgove Dennis Gove
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development