Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7499

Deprecate the "name" parameter from the ADDREPLICA Collection API call

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 5.3, 6.0
    • None
    • None

    Description

      Right now we take a "name" parameter in the ADDREPLICA call. We use that as the core name for the replica. Are there any use cases where specifying the name of the core for the replica is useful?

      Here are the disadvantages of doing so -
      1. We don't verify if the name is unique in the collection. So if a conflicting name ends up in the same node then the call will fail.
      2. If it core is created on some other node, it will fail with legacyCloud=false as that checks for uniqueness in core names.

      https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-api_addreplica - The ref guide has never documented the "name" parameter.

      Attachments

        1. SOLR-7499.patch
          4 kB
          Varun Thacker
        2. SOLR-7499.patch
          7 kB
          Varun Thacker
        3. SOLR-7499.patch
          6 kB
          Varun Thacker

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            varun Varun Thacker
            varun Varun Thacker
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment