Solr
  1. Solr
  2. SOLR-7487

check-example-lucene-match-version is looking in the wrong place - luceneMatchVersion incorrect in 5.1 sample configs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      As noted by Scott Dawson on the mailing list, the luceneMatchVersion in the 5.1 sample configs all still lists "5.0.0".

      The root cause seems to be because the check-example-lucene-match-version task in solr/build.xml is looking in the wrong place – it's still scaning for instances of luceneMatchVersion in the example directory instead of the server/solr/configset

      TODO:

      • fix the luceneMatchVersion value in all sample configsets on 5x
      • update the check to look in the correct directory
      • update the check to fail to be smarter know that we have a more predictable directory structure
        • fail if no subdirs found
        • fail if any subdir doesn't contain conf/solrconfig.xml
        • fail if any conf/solrconfig.xml doesn't contain a luceneMatchVersion
        • fail if any luceneMatchVersion doesn't have the expected value
      1. SOLR-7487.patch
        5 kB
        Timothy Potter
      2. SOLR-7487.patch
        5 kB
        Hoss Man
      3. SOLR-7487.patch
        5 kB
        Timothy Potter
      4. SOLR-7487.patch
        4 kB
        Timothy Potter

        Issue Links

          Activity

          Hide
          Timothy Potter added a comment -

          Here's a patch for 5x (trunk will also need the build.xml changes).

          My Ant foo is a bit rusty but I added a check to ensure that at least one sub-directory exists and that all immediate sub-directories of the configsets dir have a solrconfig.xml.

          Show
          Timothy Potter added a comment - Here's a patch for 5x (trunk will also need the build.xml changes). My Ant foo is a bit rusty but I added a check to ensure that at least one sub-directory exists and that all immediate sub-directories of the configsets dir have a solrconfig.xml.
          Hide
          Ryan Ernst added a comment -

          You probably want to update dev-tools/scripts/addVersion.py as well so these get updated when versions are bumped?

          Show
          Ryan Ernst added a comment - You probably want to update dev-tools/scripts/addVersion.py as well so these get updated when versions are bumped?
          Hide
          Timothy Potter added a comment -

          Yup, good catch (got hasty), thanks Ryan.

          Show
          Timothy Potter added a comment - Yup, good catch (got hasty), thanks Ryan.
          Hide
          Timothy Potter added a comment -

          Updated patch includes change to addVersion.py to walk the correct directory: solr/server/solr/configsets (was solr/example)

          Show
          Timothy Potter added a comment - Updated patch includes change to addVersion.py to walk the correct directory: solr/server/solr/configsets (was solr/example)
          Hide
          Hoss Man added a comment - - edited

          build.xml changes look good to me.

          I've updated the patch with my own crude attempt at the addVersion.py changes – totally untested since evidently addVersion requires python 3.3 (flush on print?) and that doesn't seem to be available for the ubuntu version on my laptop.

          EDIT: whoops ... didn't see you already solved that tim.

          Show
          Hoss Man added a comment - - edited build.xml changes look good to me. I've updated the patch with my own crude attempt at the addVersion.py changes – totally untested since evidently addVersion requires python 3.3 (flush on print?) and that doesn't seem to be available for the ubuntu version on my laptop. EDIT: whoops ... didn't see you already solved that tim.
          Hide
          Timothy Potter added a comment -

          Minor typo in python ... committing this now.

          Show
          Timothy Potter added a comment - Minor typo in python ... committing this now.
          Hide
          ASF subversion and git services added a comment -

          Commit 1677228 from Timothy Potter in branch 'dev/trunk'
          [ https://svn.apache.org/r1677228 ]

          SOLR-7487: Fix check-example-lucene-match-version Ant task to check luceneMatchVersion in solr/server/solr/configsets instead of example and harden error checking / validation logic.

          Show
          ASF subversion and git services added a comment - Commit 1677228 from Timothy Potter in branch 'dev/trunk' [ https://svn.apache.org/r1677228 ] SOLR-7487 : Fix check-example-lucene-match-version Ant task to check luceneMatchVersion in solr/server/solr/configsets instead of example and harden error checking / validation logic.
          Hide
          ASF subversion and git services added a comment -

          Commit 1677230 from Timothy Potter in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1677230 ]

          SOLR-7487: Fix check-example-lucene-match-version Ant task to check luceneMatchVersion in solr/server/solr/configsets instead of example and harden error checking / validation logic.

          Show
          ASF subversion and git services added a comment - Commit 1677230 from Timothy Potter in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1677230 ] SOLR-7487 : Fix check-example-lucene-match-version Ant task to check luceneMatchVersion in solr/server/solr/configsets instead of example and harden error checking / validation logic.
          Hide
          ASF subversion and git services added a comment -

          Commit 1677232 from Timothy Potter in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1677232 ]

          SOLR-7487: update luceneMatchVersion to 5.2.0 so that precommit passes

          Show
          ASF subversion and git services added a comment - Commit 1677232 from Timothy Potter in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1677232 ] SOLR-7487 : update luceneMatchVersion to 5.2.0 so that precommit passes
          Hide
          Anshum Gupta added a comment -

          Bulk close for 5.2.0.

          Show
          Anshum Gupta added a comment - Bulk close for 5.2.0.

            People

            • Assignee:
              Timothy Potter
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development