Solr
  1. Solr
  2. SOLR-7485

replace "shards.info" with ShardParams.SHARDS_INFO in TestTolerantSearch.java and CloudSolrClientTest.java, add ShardParamsTest.java

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None

      Description

      various other tests already use ShardParams.SHARDS_INFO e.g. TestDistributedSearch.java

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user cpoerschke opened a pull request:

        https://github.com/apache/lucene-solr/pull/145

        SOLR-7485: replace "shards.info" with ShardParams.SHARDS_INFO

        for https://issues.apache.org/jira/i#browse/SOLR-7485

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-shards.info

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/145.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #145


        commit c53216fe38a56246ebc47e3e89134a217f60d924
        Author: Christine Poerschke <cpoerschke@bloomberg.net>
        Date: 2015-01-15T17:11:50Z

        SOLR-????: replace "shards.info" with ShardParams.SHARDS_INFO in TestTolerantSearch.java and CloudSolrClientTest.java

        various other tests already use ShardParams.SHARDS_INFO e.g. TestDistributedSearch.java


        Show
        ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/145 SOLR-7485 : replace "shards.info" with ShardParams.SHARDS_INFO for https://issues.apache.org/jira/i#browse/SOLR-7485 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-shards.info Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/145.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #145 commit c53216fe38a56246ebc47e3e89134a217f60d924 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2015-01-15T17:11:50Z SOLR-????: replace "shards.info" with ShardParams.SHARDS_INFO in TestTolerantSearch.java and CloudSolrClientTest.java various other tests already use ShardParams.SHARDS_INFO e.g. TestDistributedSearch.java
        Hide
        Shalin Shekhar Mangar added a comment -

        Maybe having the string constants in some tests isn't that bad? If someone accidentally changes the constant's value, there will be at least 1 test which catches the back-compat break.

        Show
        Shalin Shekhar Mangar added a comment - Maybe having the string constants in some tests isn't that bad? If someone accidentally changes the constant's value, there will be at least 1 test which catches the back-compat break.
        Hide
        Christine Poerschke added a comment -

        Hi Shalin Shekhar Mangar - good point about someone accidentally changing the constant's value.

        Latest commit on the patch branch adds a ShardParamsTest for back-compat breakages for "shards.info" as well as the other ShardParams.java parameters.

        Show
        Christine Poerschke added a comment - Hi Shalin Shekhar Mangar - good point about someone accidentally changing the constant's value. Latest commit on the patch branch adds a ShardParamsTest for back-compat breakages for "shards.info" as well as the other ShardParams.java parameters.
        Hide
        Ramkumar Aiyengar added a comment -

        Shalin Shekhar Mangar, does that address your concern?

        Show
        Ramkumar Aiyengar added a comment - Shalin Shekhar Mangar , does that address your concern?
        Hide
        Christine Poerschke added a comment -

        ticket cross-reference: SOLR-7710 proposes to add a CommonAdminParamsTest to test the backwards compatibility of CommonAdminParams parameter constants (similar to the ShardParamsTest for ShardParams.java test proposed here)

        Show
        Christine Poerschke added a comment - ticket cross-reference: SOLR-7710 proposes to add a CommonAdminParamsTest to test the backwards compatibility of CommonAdminParams parameter constants (similar to the ShardParamsTest for ShardParams.java test proposed here)
        Hide
        ASF subversion and git services added a comment -

        Commit 1688025 from Ramkumar Aiyengar in branch 'dev/trunk'
        [ https://svn.apache.org/r1688025 ]

        SOLR-7485: Replace shards.info occurrences with ShardParams.SHARDS_INFO

        Show
        ASF subversion and git services added a comment - Commit 1688025 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1688025 ] SOLR-7485 : Replace shards.info occurrences with ShardParams.SHARDS_INFO
        Hide
        ASF subversion and git services added a comment -

        Commit 1688026 from Ramkumar Aiyengar in branch 'dev/trunk'
        [ https://svn.apache.org/r1688026 ]

        SOLR-7485: Add CHANGES.txt

        Show
        ASF subversion and git services added a comment - Commit 1688026 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1688026 ] SOLR-7485 : Add CHANGES.txt
        Hide
        ASF subversion and git services added a comment -

        Commit 1688027 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1688027 ]

        SOLR-7485: Replace shards.info occurrences with ShardParams.SHARDS_INFO

        Show
        ASF subversion and git services added a comment - Commit 1688027 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1688027 ] SOLR-7485 : Replace shards.info occurrences with ShardParams.SHARDS_INFO
        Hide
        Ramkumar Aiyengar added a comment -

        Thanks Christine!

        Show
        Ramkumar Aiyengar added a comment - Thanks Christine!
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release
        Hide
        ASF GitHub Bot added a comment -

        Github user cpoerschke closed the pull request at:

        https://github.com/apache/lucene-solr/pull/145

        Show
        ASF GitHub Bot added a comment - Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/145

          People

          • Assignee:
            Ramkumar Aiyengar
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development