Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7472

SortingResponseWriter does not log fl parameters that don't exist.

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.9, 4.9.1, 4.10, 4.10.1, 4.10.2, 4.10.4, 5.0, 5.1
    • 5.2
    • None
    • None

    Description

      The SortingResponseWriter, which is the response writer for the /export handler, does not log the error that is thrown when an fl is specified that does not exist.

      The reason for this is that an unchecked SolrException is being thrown from the IndexSchema. All other exceptions in SortingResponseWriter are wrapped in an IOException.

      For reasons I'm not entirely sure of the ResponseUtils class doesn't log the stacktrace for errors with codes between 500 and 100. It considers these to be normal error conditions. So the unchecked SolrException was not being logged.

      The short term fix for this is to catch the exception from the IndexSchema and wrap it in a IOException like the other exceptions from the SortingResponseWriter.

      Longer term I think it makes sense to review the ResponseUtil exception logging logic.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jbernste Joel Bernstein
            jbernste Joel Bernstein
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment