Solr
  1. Solr
  2. SOLR-7472

SortingResponseWriter does not log fl parameters that don't exist.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.9, 4.9.1, 4.10, 4.10.1, 4.10.2, 4.10.4, 5.0, 5.1
    • Fix Version/s: 5.2
    • Component/s: None
    • Labels:
      None

      Description

      The SortingResponseWriter, which is the response writer for the /export handler, does not log the error that is thrown when an fl is specified that does not exist.

      The reason for this is that an unchecked SolrException is being thrown from the IndexSchema. All other exceptions in SortingResponseWriter are wrapped in an IOException.

      For reasons I'm not entirely sure of the ResponseUtils class doesn't log the stacktrace for errors with codes between 500 and 100. It considers these to be normal error conditions. So the unchecked SolrException was not being logged.

      The short term fix for this is to catch the exception from the IndexSchema and wrap it in a IOException like the other exceptions from the SortingResponseWriter.

      Longer term I think it makes sense to review the ResponseUtil exception logging logic.

      1. SOLR-7472.patch
        0.8 kB
        Joel Bernstein

        Issue Links

          Activity

          Hide
          Joel Bernstein added a comment -

          Patch with fix

          Show
          Joel Bernstein added a comment - Patch with fix
          Hide
          ASF subversion and git services added a comment -

          Commit 1679618 from Joel Bernstein in branch 'dev/trunk'
          [ https://svn.apache.org/r1679618 ]

          SOLR-7472: SortingResponseWriter does not log fl parameters that don't exist.

          Show
          ASF subversion and git services added a comment - Commit 1679618 from Joel Bernstein in branch 'dev/trunk' [ https://svn.apache.org/r1679618 ] SOLR-7472 : SortingResponseWriter does not log fl parameters that don't exist.
          Hide
          ASF subversion and git services added a comment -

          Commit 1679619 from Joel Bernstein in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1679619 ]

          SOLR-7472: SortingResponseWriter does not log fl parameters that don't exist.

          Show
          ASF subversion and git services added a comment - Commit 1679619 from Joel Bernstein in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1679619 ] SOLR-7472 : SortingResponseWriter does not log fl parameters that don't exist.

            People

            • Assignee:
              Joel Bernstein
              Reporter:
              Joel Bernstein
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development