Solr
  1. Solr
  2. SOLR-7469

check-licenses happily ignoring incorrect start.jar.sha1, current start.jar.sha1 on trunk is out of date.

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      as of r1675948, "ant clean jar-checksums" results in a modified solr/licenses/start.jar.sha1 ...

      hossman@frisbee:~/lucene/dev$ svn diff
      Index: solr/licenses/start.jar.sha1
      ===================================================================
      --- solr/licenses/start.jar.sha1	(revision 1675948)
      +++ solr/licenses/start.jar.sha1	(working copy)
      @@ -1 +1 @@
      -24e798bde886e1430978ece6c4aa90d781e2da30
      +b91b72f9167cce4c1caea0f8363fd9984456e34d
      

      ...so apparently the version of start.jar we're fetching from ivy & using in solr changed at some point w/o the SHA1 being updated?

      apparently because "check-licenses" is explicitly ignoring start.jar...

              <!-- Exclude start.jar only (it'd be weird to have a license file there?) -->
              <exclude name="server/start.jar" />
      

      ...this is seriously messed up. we need to fix this.

        Activity

        Hide
        Hoss Man added a comment -

        patch for trunk...

        stops ignoring start.jar in check-license so we get accurate sha1 checks, and leverages additional-filters to recognize that start.jar comes from jetty and uses the jetty license.

        Show
        Hoss Man added a comment - patch for trunk... stops ignoring start.jar in check-license so we get accurate sha1 checks, and leverages additional-filters to recognize that start.jar comes from jetty and uses the jetty license.
        Hide
        ASF subversion and git services added a comment -

        Commit 1675968 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1675968 ]

        SOLR-7469: Fix check-licenses to accurately detect if start.jar.sha1 is incorrect

        Show
        ASF subversion and git services added a comment - Commit 1675968 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1675968 ] SOLR-7469 : Fix check-licenses to accurately detect if start.jar.sha1 is incorrect
        Hide
        ASF subversion and git services added a comment -

        Commit 1675969 from hossman@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1675969 ]

        SOLR-7469: Fix check-licenses to accurately detect if start.jar.sha1 is incorrect (merge r1675968)

        Show
        ASF subversion and git services added a comment - Commit 1675969 from hossman@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1675969 ] SOLR-7469 : Fix check-licenses to accurately detect if start.jar.sha1 is incorrect (merge r1675968)
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Hoss!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Hoss!
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development