Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7469

check-licenses happily ignoring incorrect start.jar.sha1, current start.jar.sha1 on trunk is out of date.

    Details

    • Type: Task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      as of r1675948, "ant clean jar-checksums" results in a modified solr/licenses/start.jar.sha1 ...

      hossman@frisbee:~/lucene/dev$ svn diff
      Index: solr/licenses/start.jar.sha1
      ===================================================================
      --- solr/licenses/start.jar.sha1	(revision 1675948)
      +++ solr/licenses/start.jar.sha1	(working copy)
      @@ -1 +1 @@
      -24e798bde886e1430978ece6c4aa90d781e2da30
      +b91b72f9167cce4c1caea0f8363fd9984456e34d
      

      ...so apparently the version of start.jar we're fetching from ivy & using in solr changed at some point w/o the SHA1 being updated?

      apparently because "check-licenses" is explicitly ignoring start.jar...

              <!-- Exclude start.jar only (it'd be weird to have a license file there?) -->
              <exclude name="server/start.jar" />
      

      ...this is seriously messed up. we need to fix this.

        Attachments

          Activity

            People

            • Assignee:
              hossman Hoss Man
              Reporter:
              hossman Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: