Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The jar is a drop in replacement, just need a trivial change to ivy-versions.properties and replacing the jar's sha1 file

        Activity

        Hide
        Hoss Man added a comment -

        Beyond some basic bug fixes, 3.1 includes 2 notable changes...

        • new static TDigest.createDigest() factory method to create "a TreeDigest of whichever type is the currently recommended type"
          • looked into switching to this to minimize code changes needed in Solr as the library itself improves in future versions, but this only helps for creating empty instances – when attempting to merge the byte[] data from multiple shards, you still have to know the concrete TDigest implementation used to know which "fromBytes" method to call – so it's not really useul to us yet (i filed https://github.com/tdunning/t-digest/issues/52)
        • new MergingDigest implementation
          • this looks interesting and might be worth switching to in the future, but based on the comments in the class level javadocs about more testing needed, and since the TDigest.createDigest() method mentioned above still uses AVLTreeDigest we should probably to leave to just leave our code alone and keep using AVLTreeDigest in Solr for now.
        Show
        Hoss Man added a comment - Beyond some basic bug fixes, 3.1 includes 2 notable changes... new static TDigest.createDigest() factory method to create "a TreeDigest of whichever type is the currently recommended type" looked into switching to this to minimize code changes needed in Solr as the library itself improves in future versions, but this only helps for creating empty instances – when attempting to merge the byte[] data from multiple shards, you still have to know the concrete TDigest implementation used to know which "fromBytes" method to call – so it's not really useul to us yet (i filed https://github.com/tdunning/t-digest/issues/52 ) new MergingDigest implementation this looks interesting and might be worth switching to in the future, but based on the comments in the class level javadocs about more testing needed, and since the TDigest.createDigest() method mentioned above still uses AVLTreeDigest we should probably to leave to just leave our code alone and keep using AVLTreeDigest in Solr for now.
        Hide
        ASF subversion and git services added a comment -

        Commit 1675949 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1675949 ]

        SOLR-7467: Upgrade t-digest to 3.1

        Show
        ASF subversion and git services added a comment - Commit 1675949 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1675949 ] SOLR-7467 : Upgrade t-digest to 3.1
        Hide
        ASF subversion and git services added a comment -

        Commit 1675963 from hossman@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1675963 ]

        SOLR-7467: Upgrade t-digest to 3.1 (merge r1675949)

        Show
        ASF subversion and git services added a comment - Commit 1675963 from hossman@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1675963 ] SOLR-7467 : Upgrade t-digest to 3.1 (merge r1675949)
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development