Solr
  1. Solr
  2. SOLR-7463

Stop forcing MergePolicy's "NoCFSRatio" based on the IWC "useCompoundFile" configuration

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Let users specify this value via setter in the solrconfig.xml, and use Lucene's default if unset (0.1).
      Document "noCFSRatio" in the ref guide.

      1. SOLR-7463.patch
        9 kB
        Tomás Fernández Löbbe
      2. SOLR-7463.patch
        6 kB
        Tomás Fernández Löbbe

        Activity

        Hide
        Tomás Fernández Löbbe added a comment -

        Here is the patch I'm proposing. I'll give people a couple of days to comment.
        I think this change could go to trunk and 5.x.

        Show
        Tomás Fernández Löbbe added a comment - Here is the patch I'm proposing. I'll give people a couple of days to comment. I think this change could go to trunk and 5.x.
        Hide
        Yonik Seeley added a comment -

        and use Lucene's default if unset (0.1)

        I see this in trunk's MergePolicy:

          protected static final double DEFAULT_NO_CFS_RATIO = 1.0;
        

        Is 0.1 set somewhere else?

        Show
        Yonik Seeley added a comment - and use Lucene's default if unset (0.1) I see this in trunk's MergePolicy: protected static final double DEFAULT_NO_CFS_RATIO = 1.0; Is 0.1 set somewhere else?
        Hide
        Tomás Fernández Löbbe added a comment -

        You are right, it's the subclasses that are setting the ratio to 0.1, TieredMergePolicy and LogMergePolicy. I still think its better to let those classes set their defaults.

        Show
        Tomás Fernández Löbbe added a comment - You are right, it's the subclasses that are setting the ratio to 0.1, TieredMergePolicy and LogMergePolicy . I still think its better to let those classes set their defaults.
        Hide
        Yonik Seeley added a comment -

        Ah, OK - sounds good.

        Show
        Yonik Seeley added a comment - Ah, OK - sounds good.
        Hide
        Tomás Fernández Löbbe added a comment -

        patch with CHANGES.txt entry (with a note in the "upgrading" section). Also added in the example solrconfig.xml the noCFSRatio example for the merge policy

        Show
        Tomás Fernández Löbbe added a comment - patch with CHANGES.txt entry (with a note in the "upgrading" section). Also added in the example solrconfig.xml the noCFSRatio example for the merge policy
        Hide
        ASF subversion and git services added a comment -

        Commit 1680663 from Tomás Fernández Löbbe in branch 'dev/trunk'
        [ https://svn.apache.org/r1680663 ]

        SOLR-7463: Stop forcing MergePolicy's ''noCFSRatio'' based on the IWC ''useCompoundFile'' configuration. Use the MP's default if not specifically set

        Show
        ASF subversion and git services added a comment - Commit 1680663 from Tomás Fernández Löbbe in branch 'dev/trunk' [ https://svn.apache.org/r1680663 ] SOLR-7463 : Stop forcing MergePolicy's ''noCFSRatio'' based on the IWC ''useCompoundFile'' configuration. Use the MP's default if not specifically set
        Hide
        ASF subversion and git services added a comment -

        Commit 1680665 from Tomás Fernández Löbbe in branch 'dev/trunk'
        [ https://svn.apache.org/r1680665 ]

        SOLR-7463: Add missing test file

        Show
        ASF subversion and git services added a comment - Commit 1680665 from Tomás Fernández Löbbe in branch 'dev/trunk' [ https://svn.apache.org/r1680665 ] SOLR-7463 : Add missing test file
        Hide
        ASF subversion and git services added a comment -

        Commit 1680673 from Tomás Fernández Löbbe in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1680673 ]

        SOLR-7463: Stop forcing MergePolicy's ''noCFSRatio'' based on the IWC ''useCompoundFile'' configuration. Use the MP's default if not specifically set

        Show
        ASF subversion and git services added a comment - Commit 1680673 from Tomás Fernández Löbbe in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1680673 ] SOLR-7463 : Stop forcing MergePolicy's ''noCFSRatio'' based on the IWC ''useCompoundFile'' configuration. Use the MP's default if not specifically set
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Tomás Fernández Löbbe
            Reporter:
            Tomás Fernández Löbbe
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development