Solr
  1. Solr
  2. SOLR-7457

Make DirectoryFactory publishing MBeanInfo extensible

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.2, 6.0
    • Component/s: JMX
    • Labels:

      Description

      In SOLR-6766, we added JMX to the HdfsDirectoryFactory. However, the implementation is pretty brittle and difficult to extend.

      It is conceivable that any implementation of DirectoryFactory might have MInfoBeans that it would like to expose, so we should explicitly accommodate that instead of relying on a side effect of the SolrResourceLoader's behaviour.

        Issue Links

          Activity

          Hide
          Mike Drob added a comment -

          Patch attached against trunk, should also apply to 5x.

          Show
          Mike Drob added a comment - Patch attached against trunk, should also apply to 5x.
          Hide
          Mark Miller added a comment -

          Patch looks good - I'll commit it.

          Show
          Mark Miller added a comment - Patch looks good - I'll commit it.
          Hide
          ASF subversion and git services added a comment -

          Commit 1676151 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1676151 ]

          SOLR-7457: Make DirectoryFactory publishing MBeanInfo extensible.

          Show
          ASF subversion and git services added a comment - Commit 1676151 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1676151 ] SOLR-7457 : Make DirectoryFactory publishing MBeanInfo extensible.
          Hide
          ASF subversion and git services added a comment -

          Commit 1676152 from Mark Miller in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1676152 ]

          SOLR-7457: Make DirectoryFactory publishing MBeanInfo extensible.

          Show
          ASF subversion and git services added a comment - Commit 1676152 from Mark Miller in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1676152 ] SOLR-7457 : Make DirectoryFactory publishing MBeanInfo extensible.
          Hide
          Mark Miller added a comment -

          Thanks Mike!

          Show
          Mark Miller added a comment - Thanks Mike!
          Hide
          Anshum Gupta added a comment -

          Bulk close for 5.2.0.

          Show
          Anshum Gupta added a comment - Bulk close for 5.2.0.

            People

            • Assignee:
              Mark Miller
              Reporter:
              Mike Drob
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development