Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2
    • Component/s: None
    • Labels:
      None

      Description

      The current general form of a facet command is:

      top_authors : { terms : {
      field : author,
      limit : 5,
      }}

      We should allow a flatter structure:

      top_authors :

      { type : terms, field : author, limit : 5 }
      1. SOLR-7422.patch
        4 kB
        Yonik Seeley

        Activity

        Hide
        Yonik Seeley added a comment -

        Here's a patch that implements the suggestion.
        Both forms continue to work because
        1. I didn't want to change all the tests
        2. Some forms are more readable with the original form, for example the degenerate form of a query fact:

        x : { query : "inStock:true" }
        vs
        x : { type : query, q : "inStock:true" }
        
        Show
        Yonik Seeley added a comment - Here's a patch that implements the suggestion. Both forms continue to work because 1. I didn't want to change all the tests 2. Some forms are more readable with the original form, for example the degenerate form of a query fact: x : { query : "inStock: true " } vs x : { type : query, q : "inStock: true " }
        Hide
        ASF subversion and git services added a comment -

        Commit 1674519 from Yonik Seeley in branch 'dev/trunk'
        [ https://svn.apache.org/r1674519 ]

        SOLR-7422: "type" param for JSON Facet API for flatter structure

        Show
        ASF subversion and git services added a comment - Commit 1674519 from Yonik Seeley in branch 'dev/trunk' [ https://svn.apache.org/r1674519 ] SOLR-7422 : "type" param for JSON Facet API for flatter structure
        Hide
        ASF subversion and git services added a comment -

        Commit 1674520 from Yonik Seeley in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1674520 ]

        SOLR-7422: "type" param for JSON Facet API for flatter structure

        Show
        ASF subversion and git services added a comment - Commit 1674520 from Yonik Seeley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1674520 ] SOLR-7422 : "type" param for JSON Facet API for flatter structure
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Yonik Seeley
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development