Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      Allow setting omitTf in the field schema. Default to true for all but text fields.

      1. SOLR-739.patch
        7 kB
        Mark Miller
      2. SOLR-739.patch
        6 kB
        Mark Miller

        Issue Links

          Activity

          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Simple patch, but my first look at Schema stuff so merits a bit of scrutiny.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Simple patch, but my first look at Schema stuff so merits a bit of scrutiny.
          Hide
          klaasm Mike Klaas added a comment -

          Haven't looked at the patch, but defaulting to omitTf=true is backwards-incompatible (think multi-valued string fields)

          Show
          klaasm Mike Klaas added a comment - Haven't looked at the patch, but defaulting to omitTf=true is backwards-incompatible (think multi-valued string fields)
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          I think it's unlikely to matter for non-text fields, but I guess we could always change the default to "false" and then update the example schema to set it to "true" everywhere except text fields.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - I think it's unlikely to matter for non-text fields, but I guess we could always change the default to "false" and then update the example schema to set it to "true" everywhere except text fields.
          Hide
          hossman Hoss Man added a comment -

          FWIW: this is a situation where reving the schema version could make sense as well (just as we did when adding multiValued, we want the default ot change but not forr existing users)

          Show
          hossman Hoss Man added a comment - FWIW: this is a situation where reving the schema version could make sense as well (just as we did when adding multiValued, we want the default ot change but not forr existing users)
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          OK, so do we have any consensus on what people think is the right approach here?
          Upping the schema version to 1.2 doesn't seem like a bad idea.
          We could even change the default for omitNorms in 1.2 also....

          Show
          yseeley@gmail.com Yonik Seeley added a comment - OK, so do we have any consensus on what people think is the right approach here? Upping the schema version to 1.2 doesn't seem like a bad idea. We could even change the default for omitNorms in 1.2 also....
          Hide
          hossman Hoss Man added a comment -

          the other possibility would be to make it FieldType specific ... leave tf in by default, but make classes where there's a 90% chance it's not need (SortableIntField, DateField, etc...) override a method disabling it.

          Show
          hossman Hoss Man added a comment - the other possibility would be to make it FieldType specific ... leave tf in by default, but make classes where there's a 90% chance it's not need (SortableIntField, DateField, etc...) override a method disabling it.
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          the other possibility would be to make it FieldType specific ... leave tf in by default, but make classes where there's a 90% chance it's not need (SortableIntField, DateField, etc...) override a method disabling it.

          That's essentially what is done in the current patch... it defaults to ommitted and TextField changes it's default to include tf.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - the other possibility would be to make it FieldType specific ... leave tf in by default, but make classes where there's a 90% chance it's not need (SortableIntField, DateField, etc...) override a method disabling it. That's essentially what is done in the current patch... it defaults to ommitted and TextField changes it's default to include tf.
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          So whats the verdict...leave as is, or should I tick the schema version?

          Show
          markrmiller@gmail.com Mark Miller added a comment - So whats the verdict...leave as is, or should I tick the schema version?
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Updated to trunk

          Ticks schema version to 1.2, >=1.2 defaults to omitTf except for TextField.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Updated to trunk Ticks schema version to 1.2, >=1.2 defaults to omitTf except for TextField.
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          Committed. Thanks Mark!

          Show
          yseeley@gmail.com Yonik Seeley added a comment - Committed. Thanks Mark!
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Can someone add a little more documentation on how it helps or when should one change the default on the wiki and example schema file?

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Can someone add a little more documentation on how it helps or when should one change the default on the wiki and example schema file?
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Good point, will do.

          • Mark
          Show
          markrmiller@gmail.com Mark Miller added a comment - Good point, will do. Mark
          Hide
          gsingers Grant Ingersoll added a comment -

          Bulk close for Solr 1.4

          Show
          gsingers Grant Ingersoll added a comment - Bulk close for Solr 1.4

            People

            • Assignee:
              Unassigned
              Reporter:
              markrmiller@gmail.com Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development