Solr
  1. Solr
  2. SOLR-7369

AngularJS UI insufficient URLDecoding in cloud/tree view

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0, 5.1
    • Fix Version/s: 5.2
    • Component/s: web gui
    • Labels:
      None

      Description

      The new Angular Admin UI has problems showing nodes in the cloud->tree men on level 2 or containing / or _. You get ugly exception instead.

      Reason is that these come escaped in link and the cloud.js script only attempts to replace first %2F=>/.

      1. SOLR-7369.patch
        1 kB
        Jan Høydahl
      2. SOLR-7369.patch
        0.7 kB
        Jan Høydahl

        Activity

        Hide
        Jan Høydahl added a comment -

        Simple fix

        Show
        Jan Høydahl added a comment - Simple fix
        Hide
        Erick Erickson added a comment -

        Jan:

        Glad to see someone is giving the Angular JS stuff a whirl! As you can tell, it's early days yet, and there are also some things not yet implemented.

        Anyway, do you want to commit this or should I?

        Show
        Erick Erickson added a comment - Jan: Glad to see someone is giving the Angular JS stuff a whirl! As you can tell, it's early days yet, and there are also some things not yet implemented. Anyway, do you want to commit this or should I?
        Hide
        Jan Høydahl added a comment -

        Yep, I've assigned myself with the intention to complete it.

        Show
        Jan Høydahl added a comment - Yep, I've assigned myself with the intention to complete it.
        Hide
        Jan Høydahl added a comment -

        Improved patch. Also improved regex that selects the path query parameter part of the URL, because the old regex was sloppy and assumed path always being at the end of the URL, which may not always hold true:

        var path = decodeURIComponent(link.replace(/.*[\\?&]path=([^&#]*).*/, "$1"));
        
        Show
        Jan Høydahl added a comment - Improved patch. Also improved regex that selects the path query parameter part of the URL, because the old regex was sloppy and assumed path always being at the end of the URL, which may not always hold true: var path = decodeURIComponent(link.replace(/.*[\\?&]path=([^&#]*).*/, "$1" ));
        Hide
        ASF subversion and git services added a comment -

        Commit 1672637 from janhoy@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1672637 ]

        SOLR-7369: AngularJS UI insufficient URLDecoding in cloud/tree view

        Show
        ASF subversion and git services added a comment - Commit 1672637 from janhoy@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1672637 ] SOLR-7369 : AngularJS UI insufficient URLDecoding in cloud/tree view
        Hide
        ASF subversion and git services added a comment -

        Commit 1672643 from janhoy@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1672643 ]

        SOLR-7369: AngularJS UI insufficient URLDecoding in cloud/tree view (merged)

        Show
        ASF subversion and git services added a comment - Commit 1672643 from janhoy@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1672643 ] SOLR-7369 : AngularJS UI insufficient URLDecoding in cloud/tree view (merged)
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Jan Høydahl
            Reporter:
            Jan Høydahl
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development