[SOLR-7361] Main Jetty thread blocked by core loading delays HTTP listener from binding if core loading is slow

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.3, 6.0
• Component/s: SolrCloud
• Assignee: Mark Miller
• Reporter: Timothy Potter
• Created: 07/Apr/15 18:44
• Updated: 09/May/16 18:54
• Resolved: 29/May/15 14:29

Description

During server startup, the CoreContainer uses an ExecutorService to load cores in multiple back-ground threads but then blocks until cores are loaded, see: CoreContainer#load around line 290 on trunk (invokeAll). From the JavaDoc on that method, we have:

Executes the given tasks, returning a list of Futures holding their status and results when all complete. Future.isDone() is true for each element of the returned list.

In other words, this is a blocking call.

This delays the Jetty HTTP listener from binding and accepting requests until all cores are loaded. Do we need to block the main thread?

Also, prior to this happening, the node is registered as a live node in ZK, which makes it a candidate for receiving requests from the Overseer, such as to service a create collection request. The problem of course is that the node listed in /live_nodes isn't accepting requests yet. So we either need to unblock the main thread during server loading or maybe wait longer before we register as a live node ... not sure which is the better way forward?

Issue Links

• is duplicated by: SOLR-7416 Slow loading SolrCores should not hold up all other SolrCores that have finished loading from serving requests.