Solr
  1. Solr
  2. SOLR-7324

No need to call isIndexStale if full copy is already needed

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.10.4
    • Fix Version/s: 5.2, 6.0
    • Component/s: replication (java)
    • Labels:
      None

      Description

      During replication, we had a message "File _3ww7_Lucene41_0.tim expected to be 2027667 while it is 1861076" when in fact there was already a match on commit.getGeneration() >= latestGeneration

      So this extra operation is not needed.

      1. SOLR-7324.patch
        1.0 kB
        Varun Thacker

        Activity

        Hide
        Varun Thacker added a comment -

        Hi Stephan,

        Nice catch! Yes we don't need to check again if we already know that the we need to download the entire index.

        Attached patch against trunk which addresses the issue. I still need to run the tests.

        Show
        Varun Thacker added a comment - Hi Stephan, Nice catch! Yes we don't need to check again if we already know that the we need to download the entire index. Attached patch against trunk which addresses the issue. I still need to run the tests.
        Show
        Stephan Lagraulet added a comment - My pull request for this: https://github.com/stephlag/lucene-solr/commit/1409f4ed7827e155677a2933801e1d491f2d72fa
        Hide
        ASF subversion and git services added a comment -

        Commit 1670359 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1670359 ]

        SOLR-7324: IndexFetcher does not need to call isIndexStale if full copy is already needed

        Show
        ASF subversion and git services added a comment - Commit 1670359 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1670359 ] SOLR-7324 : IndexFetcher does not need to call isIndexStale if full copy is already needed
        Hide
        ASF subversion and git services added a comment -

        Commit 1670420 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1670420 ]

        SOLR-7324: IndexFetcher does not need to call isIndexStale if full copy is already needed (merged trunk r1670359)

        Show
        ASF subversion and git services added a comment - Commit 1670420 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1670420 ] SOLR-7324 : IndexFetcher does not need to call isIndexStale if full copy is already needed (merged trunk r1670359)
        Hide
        Varun Thacker added a comment -

        Thanks Stephan!

        Show
        Varun Thacker added a comment - Thanks Stephan!
        Hide
        ASF subversion and git services added a comment -

        Commit 1670571 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1670571 ]

        SOLR-7324: Move CHANGES entry under 5.2

        Show
        ASF subversion and git services added a comment - Commit 1670571 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1670571 ] SOLR-7324 : Move CHANGES entry under 5.2

          People

          • Assignee:
            Varun Thacker
            Reporter:
            Stephan Lagraulet
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development