Solr
  1. Solr
  2. SOLR-7305

BlendedInfixLookupFactory swallows root ioexception when it occurs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.10.4, 6.0
    • Fix Version/s: 5.1, 6.0
    • Component/s: Suggester
    • Labels:
      None

      Description

      See BlendedInfixLookupFactory.java line 105:

          try {
            return new BlendedInfixSuggester(core.getSolrConfig().luceneMatchVersion, 
                                             FSDirectory.open(new File(indexPath)),
                                             indexAnalyzer, queryAnalyzer, minPrefixChars,
                                             blenderType, numFactor);
          } catch (IOException e) {
            throw new RuntimeException();
          }
      

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user stephlag opened a pull request:

        https://github.com/apache/lucene-solr/pull/137

        Fix SOLR-7305

        Does not correct the underlying exception (which occurs on a core reload) but exposes the root cause

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/stephlag/lucene-solr patch-2

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/137.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #137


        commit fb5ea39ae242e3e5b36f8bb52b24a20ac5606d40
        Author: Stephan L <stefanl2@yahoo.fr>
        Date: 2015-03-25T11:28:45Z

        Fix SOLR-7305

        Does not correct the underlying exception (which occurs on a core reload) but exposes the root cause


        Show
        ASF GitHub Bot added a comment - GitHub user stephlag opened a pull request: https://github.com/apache/lucene-solr/pull/137 Fix SOLR-7305 Does not correct the underlying exception (which occurs on a core reload) but exposes the root cause You can merge this pull request into a Git repository by running: $ git pull https://github.com/stephlag/lucene-solr patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit fb5ea39ae242e3e5b36f8bb52b24a20ac5606d40 Author: Stephan L <stefanl2@yahoo.fr> Date: 2015-03-25T11:28:45Z Fix SOLR-7305 Does not correct the underlying exception (which occurs on a core reload) but exposes the root cause
        Hide
        ASF subversion and git services added a comment -

        Commit 1669180 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1669180 ]

        SOLR-7305: BlendedInfixLookupFactory swallows root IOException when it occurs. This closes #137

        Show
        ASF subversion and git services added a comment - Commit 1669180 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1669180 ] SOLR-7305 : BlendedInfixLookupFactory swallows root IOException when it occurs. This closes #137
        Hide
        ASF subversion and git services added a comment -

        Commit 1669186 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1669186 ]

        SOLR-7305: BlendedInfixLookupFactory swallows root IOException when it occurs. This closes #137

        Show
        ASF subversion and git services added a comment - Commit 1669186 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1669186 ] SOLR-7305 : BlendedInfixLookupFactory swallows root IOException when it occurs. This closes #137
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Stephan!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Stephan!
        Hide
        ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/lucene-solr/pull/137

        Show
        ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/137
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Stephan Lagraulet
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development