Solr
  1. Solr
  2. SOLR-728

Add synchronization to avoid race condition of multiple imports working concurrently

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      see http://www.nabble.com/dataimporthandler-and-multiple-delta-import-td19160129.html
      DataimportHandler import command should check if status is not idle, to avoid race conditions

      1. SOLR-728.patch
        4 kB
        Shalin Shekhar Mangar
      2. SOLR-728.patch
        4 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Marking this bug for 1.3

        Show
        Shalin Shekhar Mangar added a comment - Marking this bug for 1.3
        Hide
        Shalin Shekhar Mangar added a comment -

        Unmarking this for 1.3 – the changes may be too invasive. We shall fix this in the next release.

        Show
        Shalin Shekhar Mangar added a comment - Unmarking this for 1.3 – the changes may be too invasive. We shall fix this in the next release.
        Hide
        Shalin Shekhar Mangar added a comment -

        Patch which uses ReentrantLock in DataImporter to make sure only one import is running at a given time.

        I'll commit this in a day or two.

        Show
        Shalin Shekhar Mangar added a comment - Patch which uses ReentrantLock in DataImporter to make sure only one import is running at a given time. I'll commit this in a day or two.
        Hide
        Shalin Shekhar Mangar added a comment -

        The previous patch did not pass the test due to incorrect logic when dealing with first use.

        Attached patch fixes it. I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - The previous patch did not pass the test due to incorrect logic when dealing with first use. Attached patch fixes it. I'll commit this shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 707295.

        Thanks Walter!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 707295. Thanks Walter!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Walter Ferrara
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development